Introduction of the adapter pattern for flexible datasources #608

pehbehbeh · 2024-09-20T16:18:49Z

This is a WIP draft of the introduction of Backpex.Adapter and a Backpex.Adapters.Ecto. This will help us support other datasources (like Ash) in the future.

This PR also introduces validation for given options to Backpex.LiveResource via nimble_options.

# Conflicts: # lib/backpex/resource.ex

Flo0807 · 2024-10-25T11:12:08Z

I just noticed that deleting the last HasManyThrough relation does not work anymore:

demo.mov
I tested the newest version of develop and everything seems to work fine there, so this MR breaks it.

It works if there is at least one HasManyThrough relation left, so deleting one out of two addresses works.

Ok, the reason is that we do not pass the assocs to the change function anymore.

lib/backpex/live_components/form_component.ex

lib/backpex/fields/has_many_through.ex

Flo0807 · 2024-10-28T08:53:21Z

I just noticed that deleting the last HasManyThrough relation does not work anymore:

demo.mov
I tested the newest version of develop and everything seems to work fine there, so this MR breaks it.

It works if there is at least one HasManyThrough relation left, so deleting one out of two addresses works.

Fixed.

lib/backpex/resource.ex

lib/backpex/adapters/ash.ex

Flo0807 · 2024-10-28T12:12:56Z

lib/backpex/adapters/ash.ex

@@ -0,0 +1,114 @@
+if Code.ensure_loaded?(Ash) do


Is there a better way to do this?

pehbehbeh added 7 commits September 20, 2024 15:56

install nimble_options

cffd41d

add adapters docs group

9d0f9a6

implement nimble_options validation for LiveResource

72bcfaa

adjust all demo resources to new adapter_config syntax

5150fb4

add basic upgrade guide

1ffeca4

start implementation of the adapter pattern and a basic ecto adapter

53100e6

improve migration guide

fa64768

pehbehbeh added the feature New feature label Sep 20, 2024

pehbehbeh added 22 commits September 26, 2024 13:41

Merge branch 'develop' into feature/adapters

5dc9d39

# Conflicts: # lib/backpex/resource.ex

implement get and get! adapter callbacks and move item_query

63f0111

implement lost adapter callbacks and move more stuff

d0c79b4

remove duplicate code

7e137db

implement count adapter callback and move more stuff

e183212

remove deprecated Resource.delete function

754ade2

remove deprecated Resource.metric_data function

53b5b4e

simplify call_changeset_function

e194a4d

first steps towards moving insert/update/change stuff to adapters

6a18042

move update_all to adapter

8342bf6

please credo

e2cf868

change primary_key to be a live_resource setting

928e384

implement very basic draft of an ash adapter

5993ca2

fix unused alias

89dbafe

fix Resource.get

2224ba9

add workaround for ecto seeds

a7978c5

Merge branch 'develop' into feature/adapters

4c90ac7

implement init_order changes from #628 for new structure

f1a7839

add warnings to adapter and ash adapter

258579a

change blog category back to ecto

edee0ea

improve docs

f292ba0

add ash helpdesk demo

9b500df

Flo0807 reviewed Oct 25, 2024

View reviewed changes

lib/backpex/live_components/form_component.ex Show resolved Hide resolved

Flo0807 reviewed Oct 25, 2024

View reviewed changes

lib/backpex/live_components/form_component.ex Show resolved Hide resolved

Flo0807 reviewed Oct 25, 2024

View reviewed changes

lib/backpex/fields/has_many_through.ex Outdated Show resolved Hide resolved

Flo0807 added 5 commits October 25, 2024 15:08

Remove backpex prefix in pubsub docs

e765249

Add upgrade guide to extras

158a750

Improve upgrade guide

96ff2d4

Pass assocs to changeset functions

8a669d5

Rename datalayer to data layer

49b9bae

Flo0807 self-assigned this Oct 28, 2024

Flo0807 added breaking-change A breaking change and removed feature New feature labels Oct 28, 2024

Flo0807 added 4 commits October 28, 2024 09:57

Fix index edit

4eeeda8

Use correct primary key for has many through

939a54a

Update docs

d44b3c0

Ensure Ash is loaded in ash adapter

c0f3f84

Flo0807 reviewed Oct 28, 2024

View reviewed changes

lib/backpex/resource.ex Outdated Show resolved Hide resolved

Flo0807 reviewed Oct 28, 2024

View reviewed changes

lib/backpex/resource.ex Outdated Show resolved Hide resolved

Flo0807 added 2 commits October 28, 2024 12:27

Update list function signature

4ce88ea

Update count function signature

e39615f

Flo0807 reviewed Oct 28, 2024

View reviewed changes

lib/backpex/adapters/ash.ex Outdated Show resolved Hide resolved

Flo0807 added 4 commits October 28, 2024 13:04

Update item query guide

d24de8b

Update ordering guide

df0be0e

Update upgrade guide

d64704f

Update upgrade guide

ad75a39

Flo0807 reviewed Oct 28, 2024

View reviewed changes

lib/backpex/adapters/ash.ex

@@ -0,0 +1,114 @@

if Code.ensure_loaded?(Ash) do

Copy link

Collaborator

Flo0807 Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a better way to do this?

Update upgrade guide

1a596e0

Flo0807 merged commit 30b9a32 into develop Oct 29, 2024
6 checks passed

Flo0807 deleted the feature/adapters branch October 29, 2024 06:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduction of the adapter pattern for flexible datasources #608

Introduction of the adapter pattern for flexible datasources #608

pehbehbeh commented Sep 20, 2024 •

edited

Loading

Flo0807 commented Oct 25, 2024

Flo0807 commented Oct 28, 2024

Flo0807 Oct 28, 2024

Introduction of the adapter pattern for flexible datasources #608

Introduction of the adapter pattern for flexible datasources #608

Conversation

pehbehbeh commented Sep 20, 2024 • edited Loading

Flo0807 commented Oct 25, 2024

Flo0807 commented Oct 28, 2024

Flo0807 Oct 28, 2024

Choose a reason for hiding this comment

pehbehbeh commented Sep 20, 2024 •

edited

Loading