Open PKCS7 data files in binary format #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we were reading files in text mode. This was causing all of the 0x0d0a line breaks to be converted to unix line breaks. This will cause issues when comparing hashes of files. If we read the files in binary mode (fopen "rb") then we avoid this conversion. Signed-off-by: Nick Child <nick.child@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were reading files in text mode. This was causing all of the 0x0d0a line breaks to be converted to unix line breaks. This will cause issues when comparing hashes of files. If we read the files in binary mode (fopen "rb") then we avoid this conversion.
Signed-off-by: Nick Child nick.child@ibm.com