Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoflake nbqa hook #461

Merged
merged 8 commits into from
Nov 14, 2020
Merged

Conversation

girip11
Copy link
Contributor

@girip11 girip11 commented Nov 14, 2020

closes #313

On branch autoflake_hook
Your branch is up to date with 'upstream/master'.
Changes to be committed:
	modified:   docs/examples.rst
@codecov-io
Copy link

codecov-io commented Nov 14, 2020

Codecov Report

Merging #461 (9060e37) into master (2dddd8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #461   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          713       713           
=========================================
  Hits           713       713           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dddd8b...9060e37. Read the comment docs.

@girip11
Copy link
Contributor Author

girip11 commented Nov 14, 2020

nbqa could support autoflake from 0.4.0 onwards (but unofficially). With these changes we have added tests for autoflake, added pre-commit hook and updated the documentation.

This could be put in the changelog for the next release.

@girip11 girip11 marked this pull request as ready for review November 14, 2020 04:15
@MarcoGorelli
Copy link
Collaborator

cool, thanks! I've just put the hooks/examples in alphabetical order

@s-weigand
Copy link
Contributor

Instead of removing the anchor, we could use linkcheck_anchors_ignore in conf.py.

@sourcery-ai
Copy link

sourcery-ai bot commented Nov 14, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.50%.

Quality metrics Before After Change
Complexity 0.00 ⭐ 0.00 ⭐ 0.00
Method Length 115.00 🙂 119.00 🙂 4.00 👎
Working memory 8.00 🙂 8.00 🙂 0.00
Quality 71.28% 🙂 70.78% 🙂 -0.50% 👎
Other metrics Before After Change
Lines 147 148 1
Changed files Quality Before Quality After Quality Change
docs/conf.py 71.28% 🙂 70.78% 🙂 -0.50% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@MarcoGorelli
Copy link
Collaborator

Instead of removing the anchor, we could use linkcheck_anchors_ignore in conf.py.

thanks!

@MarcoGorelli MarcoGorelli merged commit c5e532b into nbQA-dev:master Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example / test for autoflake
4 participants