Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Emojis mess up layout #96

Closed
felixfbecker opened this issue Jun 1, 2019 · 3 comments
Closed

Emojis mess up layout #96

felixfbecker opened this issue Jun 1, 2019 · 3 comments
Labels
bug Something isn't working
Milestone
0.9.0

Comments

@felixfbecker
Copy link

iTerm2:

image

term2svg:

image

out.log
@felixfbecker
Copy link
Author

Also, ESC[2m (dimmed) has no effect.

nbedos added a commit that referenced this issue Jun 30, 2019
@nbedos
Fix text length computation (#96)
391d998
@nbedos
Copy link
Owner

nbedos commented Jun 30, 2019

Good find, I didn't take into account that some Unicode characters take the space of 2 or more 'regular' characters. This should be fixed by 391d998.

Also, ESC[2m (dimmed) has no effect.

Unfortunately this is not handled by Pyte (which termtosvg uses to decode escape sequences).

@nbedos nbedos added the bug Something isn't working label Jun 30, 2019
@nbedos nbedos added this to the 0.9.0 milestone Jun 30, 2019
@nbedos
Copy link
Owner

nbedos commented Jul 6, 2019

Fixed in https://github.com/nbedos/termtosvg/releases/tag/0.9.0

@nbedos nbedos closed this as completed Jul 6, 2019
@polarathene polarathene mentioned this issue Jul 24, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@felixfbecker @nbedos