-
Notifications
You must be signed in to change notification settings - Fork 437
Conversation
Hey man, thanks for contributing the first pull request :) I do agree that termtosvg needs a way to customize the font used, but I think it belongs with color themes and should be set by the 'font' resource of Xresources. This way it can be set for both the terminal (xterm, urxvt...) and termtosvg in a single place. This would probably require the following steps:
One last gotcha: termtosvg uses hardcoded numbers for character cells width and height. I picked those numbers for Deja Vu Sans Mono and a 14 pixels font size, so they are probably not suitable for all fonts. At some point it might be necessary to expose them so that they can be set by the user (or even better, to compute them based on the name of the font, but I can't seem to find a way to do that that gives reliable results) Let me know if you wish to work on this, or are willing to help testing (I definitely need help for that). In any case I'll probably take a deeper look at this this weekend. Thanks again |
Hello !
Does this looks good to you (before we get a better view with asciicast) ?
|
With a contribution by ylmrx (Pull request #3)
I have replaced the configuration via Xresources by a simple INI file, and I have also implemented the font option based on your commits. Thanks! I did not add the font to Asciicast records since the font is not detected on the system: it's just a configuration option. I have not released this version to the production pypi server yet, but you can dowload it from the test server:
The updated README is available here: https://github.com/nbedos/termtosvg/tree/release/0.3.0 Let me know what you think! |
I have just released version 0.3.0 which includes the font option. |
Don't worry about updating your branch, it's ok. I had to do other changes before including your commits in my tree and I didn't want to bother you with a rebase. Your modifications have been added though the following commit : d930740 |
Thanks for your awesome work :) I hope you find this patch useful.