This repository has been archived by the owner on Jun 16, 2020. It is now read-only.
Add underscore and strikethrough text rendering support #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's all good! I just added default values for some arguments of CharacterCell.new, and I also added a few test cases. As for line length, I try to stay under 100 characters, except for type hints since they can't be split across multiple lines. Thanks again! |
nbedos
added
merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added support for underlined and strikethrough text. pyte already supported it.
Also, I split the lines I added at 80 chars. I'm not sure if this is how you'd like them to be; it is a bit inconsistent in the rest of the code.