Skip to content
This repository has been archived by the owner on Jun 16, 2020. It is now read-only.

Ship manuals and tests with package #77

Merged
merged 3 commits into from
Nov 11, 2018
Merged

Ship manuals and tests with package #77

merged 3 commits into from
Nov 11, 2018

Conversation

polyzen
Copy link
Contributor

@polyzen polyzen commented Nov 6, 2018

No description provided.

@nbedos
Copy link
Owner

nbedos commented Nov 10, 2018

Thanks for the pull request. What's the rationale behind these changes?
Manual pages could be included in the package but pip won't install them in the proper location.
What's the use of having tests in the package?

@polyzen
Copy link
Contributor Author

polyzen commented Nov 10, 2018

So one could run the tests and install the manual pages, specifically as part of building a distro package:
https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=termtosvg

Eg. https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=xandikos

Once the package is installed, all tests can be run with
`python -m unittest termtosvg.tests.suite`
@nbedos
Copy link
Owner

nbedos commented Nov 10, 2018

I see! Thanks for working on the AUR package.

I've included all tests in the package and I've also set up a test suite so that all tests can be run with python -m unittest termtosvg.tests.suite.

Does that look good?

@polyzen
Copy link
Contributor Author

polyzen commented Nov 10, 2018

Even better! Wish more projects utilized the test suite feature.

@nbedos nbedos merged commit c68e344 into nbedos:develop Nov 11, 2018
@nbedos nbedos added the merged This pull request was merged label Nov 11, 2018
@nbedos
Copy link
Owner

nbedos commented Nov 11, 2018

Merged, thanks again! Let me know if you're facing problems with packaging.

@polyzen
Copy link
Contributor Author

polyzen commented Nov 15, 2018

Would you be willing to do a patch release for this?

@eli-schwartz
Copy link

Generally speaking, one is supposed to have the testsuite run in the source tree, not install it as end-user code.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
merged This pull request was merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants