Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation errors in tests #91

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

jturner314
Copy link
Contributor

@jturner314 jturner314 commented Aug 2, 2021

See rust-ndarray/ndarray#1051. I think these changes will fix the errors, but I haven't tested them. An alternative would be to change .into_iter() to .iter(); I'm not sure which approach is better.

See rust-ndarray/ndarray#1051. I think these changes will fix the errors, but I haven't tested them.
@bluss
Copy link

bluss commented Aug 2, 2021

I would recommend users to use .iter() when possible (it should be a faster iterator?).

This probably runs faster.
@codecov-commenter
Copy link

Codecov Report

Merging #91 (8a035d7) into master (312952b) will decrease coverage by 4.98%.
The diff coverage is 2.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
- Coverage   16.11%   11.13%   -4.99%     
==========================================
  Files          19       21       +2     
  Lines        1117     1608     +491     
==========================================
- Hits          180      179       -1     
- Misses        937     1429     +492     
Impacted Files Coverage Δ
onnxruntime-sys/build.rs 0.00% <0.00%> (ø)
...runtime-sys/src/generated/linux/x86_64/bindings.rs 0.00% <ø> (ø)
...untime-sys/src/generated/macos/aarch64/bindings.rs 0.00% <0.00%> (ø)
...runtime-sys/src/generated/macos/x86_64/bindings.rs 0.00% <ø> (ø)
onnxruntime/src/download.rs 0.00% <0.00%> (ø)
onnxruntime/src/environment.rs 89.83% <ø> (ø)
onnxruntime/src/error.rs 62.50% <ø> (ø)
onnxruntime/src/lib.rs 41.48% <0.00%> (-1.07%) ⬇️
onnxruntime/src/session.rs 0.00% <0.00%> (ø)
onnxruntime/src/tensor/ort_tensor.rs 79.16% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5249646...8a035d7. Read the comment docs.

@nbigaouette
Copy link
Owner

Awesome, thanks a lot!

@nbigaouette nbigaouette merged commit 3db6479 into nbigaouette:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants