Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: remove the commit fee clamp, add max fee #29

Open
wants to merge 3 commits into
base: geewalletLightningMilestone12
Choose a base branch
from

Conversation

aarani
Copy link

@aarani aarani commented Apr 12, 2023

This commit removes the check that compares mutual close fee with commit tx fee, this check is outdated and has been changed by this spec PR [1].

To prevent unreasonably high fee, this commit introduces MutualCloseMaxFeeMultiplier setting.

[1] lightning/bolts#847

@aarani aarani force-pushed the fixFeeCalculation branch 3 times, most recently from 6b4bb58 to 5668284 Compare April 12, 2023 11:45
aarani and others added 3 commits April 12, 2023 15:31
This commit fixes the issue caused by YoloDev.Expecto.TestSdk
upgrade to netcoreapp3.1.
Since compiler sometimes complains that it doesn't know which overload to use.
Instead we just prepare constructors for each integral types.

Might be related to dotnet/fsharp#1565
This commit removes the check that compares mutual
close fee with commit tx fee, this check is outdated
and has been changed by this spec PR [1].

To prevent unreasonably high fee, this commit introduces
MutualCloseMaxFeeMultiplier setting.

[1] lightning/bolts#847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants