Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct channel ID in WaitForFundingSigned #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

canndrew
Copy link
Member

@canndrew canndrew commented Jul 16, 2020

This makes geewallet's OutgoingUnfundedChannel report the correct/true channel id, rather than the temporary channel id used during the initial stage of channel opening.

@knocte
Copy link
Member

knocte commented Jul 16, 2020

The commit message needs to be fixed: it only has a title (I guess you forgot to copy+paste the description from the PR into it?).

Also now that you're gonna change the commit message, please add a link to the commit in official DNL that is the same as this one.

This makes geewallet's OutgoingUnfundedChannel report the correct/true
channel id, rather than the temporary channel id used during the initial
stage of channel opening.

This is commit 6f1175a in upstream DNL.
@canndrew canndrew force-pushed the nblockchain-master-wait-for-funding-signed-channel-id-fix branch from 3e48d7b to fda35ef Compare July 16, 2020 08:10
@canndrew
Copy link
Member Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants