Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix json marshalling #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Aug 18, 2020

  1. Revert "bump NBitcoin version 5.0.41 -> 5.0.49"

    This reverts commit 21fb15e,
    because:
    
    - There was no motivation for this upgrade (nothing specified
    in the commit message).
    - It might introduce bugs that we don't want to deal with, at
    the moment.
    - We might revert this revert shortly after finishing our
    milestone4 (closing channels).
    knocte committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    48f7e60 View commit details
    Browse the repository at this point in the history
  2. Mono-hop unidirectional payments

    canndrew authored and knocte committed Aug 18, 2020
    Configuration menu
    Copy the full SHA
    cae6b93 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2020

  1. Fix chain hashes being serialized in reverse

    This is a fix for changes introduced in
    joemphilips#118 which caused
    chain hashes to get serialized in reverse order.
    canndrew authored and knocte committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    a0ea6e1 View commit details
    Browse the repository at this point in the history
  2. Redefine single-variant discriminated union types

    A lot of types in DotNetLightning are defined as discriminated unions
    with a single constructor with the same name as the type. eg:
    
        type NodeId = | NodeId PubKey
    
    This commit redefines these types as:
    
        type NodeId(id: PubKey) = ...
    
    The main motivation for this is that having types and constructors with
    the same name breaks the json serialization library on older mono
    versions. It can also lead to confusing error messages. Besides that,
    it's also somewhat pointless to define a type as a discriminated union
    but then only give it one variant.
    canndrew committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    1820f86 View commit details
    Browse the repository at this point in the history
  3. Add JsonMarshalling module

    This commit adds the JsonMarshalling module which defines json
    serialization converters for a bunch of types exported by
    DotNetLightning. This allows the consumer of DotNetLightning to
    serialize the channel state to a wallet file.
    canndrew committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    afd7f3a View commit details
    Browse the repository at this point in the history