Core,Grpc.Service: make SendMarketOrder return

Make SendMarketOrder return a Match instead of unit.
nblockchain · Sep 3, 2024 · fb814ad · fb814ad
1 parent 5497e37
commit fb814ad
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/FX.Core/Exchange.fs b/src/FX.Core/Exchange.fs
@@ -14,8 +14,8 @@ type public Exchange(persistenceType: Persistence) =
         with get (market: Market): OrderBook =
             marketStore.GetOrderBook market
 
-    member __.SendMarketOrder (order: OrderInfo, market: Market): unit =
-        marketStore.ReceiveOrder (OrderRequest.Market(order)) market |> ignore
+    member __.SendMarketOrder (order: OrderInfo, market: Market): Option<Match> =
+        marketStore.ReceiveOrder (OrderRequest.Market(order)) market
 
     member __.SendLimitOrder (order: LimitOrderRequest, market: Market): Option<Match> =
         marketStore.ReceiveOrder (OrderRequest.Limit(order)) market

diff --git a/src/FX.GrpcService/Services/FXService.cs b/src/FX.GrpcService/Services/FXService.cs
@@ -30,18 +30,18 @@ public override async Task<GenericOutputParam> GenericMethod(GenericInputParam r
                 var marketForLimitOrder = new Market(Currency.BTC, Currency.USD);
 
                 // TODO: make async
-                var matchType = exchange.SendLimitOrder(limitOrderReq, marketForLimitOrder);
-                return await Task.FromResult(new GenericOutputParam { MsgOut = GrpcModels.Marshaller.Serialize(matchType) });
+                var match = exchange.SendLimitOrder(limitOrderReq, marketForLimitOrder);
+                return await Task.FromResult(new GenericOutputParam { MsgOut = GrpcModels.Marshaller.Serialize(match) });
             }
             else if (deserializedRequest is GrpcModels.MarketOrder { } marketOrder)
             {
                 var orderInfo = new OrderInfo(Guid.NewGuid(), Side.Parse(marketOrder.Side), marketOrder.Quantity);
                 var marketForMarketOrder = new Market(Currency.BTC, Currency.USD);
 
                 // TODO: make async
-                exchange.SendMarketOrder(orderInfo, marketForMarketOrder);
+                var match = exchange.SendMarketOrder(orderInfo, marketForMarketOrder);
                 // return empty string?
-                return await Task.FromResult(new GenericOutputParam { MsgOut = String.Empty });
+                return await Task.FromResult(new GenericOutputParam { MsgOut = GrpcModels.Marshaller.Serialize(match) });
             }
             else if (deserializedRequest is GrpcModels.CancelOrderRequest { } cancelOrderRequest)
             {