-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample.Gtk: build SourceGen separately #21
base: master
Are you sure you want to change the base?
Sample.Gtk: build SourceGen separately #21
Commits on Mar 8, 2023
-
We changed the dotnet version to 6.0.300 to ultimately use GtkSharp pre-built packages instead of cloning the repo. Co-authored-by: webwarrior-ws <reg@webwarrior.ws> Co-authored-by: Parham Saremi <parhaamsaremi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 72f48c4 - Browse repository at this point
Copy the full SHA 72f48c4View commit details -
Controls.Sample.Gtk: fix build
Error: /home/runner/work/maui/maui/src/Controls/samples/Controls.Sample.Gtk/SimpleSampleApp/SimpleSampleGtkApplication.cs(28,5): error CS0117: 'Box' does not contain a definition for 'Fill'
Configuration menu - View commit details
-
Copy full SHA for 7a1e1b4 - Browse repository at this point
Copy the full SHA 7a1e1b4View commit details -
GitHubCI: remove label-partner-issues (lytico#3)
It was throwing some error in our PRs CI, and this seems Microsoft-specific.
Configuration menu - View commit details
-
Copy full SHA for c32cd0c - Browse repository at this point
Copy the full SHA c32cd0cView commit details -
Compatibility/Gtk: add FontNamedSizeService gtk
FontNamedSizeService is needed when using `Fontsize=Large` or `Fontsize=Small` in Xaml files. Without this service, we get runtime errors when trying to parse Xaml files that have Fontsize attribute in them.
Configuration menu - View commit details
-
Copy full SHA for fc9f862 - Browse repository at this point
Copy the full SHA fc9f862View commit details -
Platform/Gtk: set MainWindow for size
These changes are necessary for having access to MainWindow in MauiGtkApplication. Initially, this field was always null and was never set. We needed access to MainWindow to do manual operations like resize on it because the applications might want to specify custom size of the window. Co-authored-by: webwarrior-ws <reg@webwarrior.ws>
Configuration menu - View commit details
-
Copy full SHA for 32ec214 - Browse repository at this point
Copy the full SHA 32ec214View commit details -
Platform/Gtk: remove debug borders from Layouts
When TRACE_ALLOCATION constant is defined, some debug borders with width and heights is shown for layouts. By disabling them, the debug values are removed from the final output.
Configuration menu - View commit details
-
Copy full SHA for 0d20a97 - Browse repository at this point
Copy the full SHA 0d20a97View commit details -
Core: fix Label line break mode in Gtk
Made label widget in Gtk respect LineBreakMode and MaxLines properties, the way it does on other platforms. By doing this labels won't crop text with dashes in any part of the word and they keep the words complete. These properties were added to ILabel interface, as it is in MAUI main branch.
Configuration menu - View commit details
-
Copy full SHA for 8be2f14 - Browse repository at this point
Copy the full SHA 8be2f14View commit details -
Platform/Gtk: workaround for layout rsize problem
Layout size is messed up after window looses or gains focus. Which is fixed by not returning the cached value. Co-authored-by: webwarrior-ws <reg@webwarrior.ws>
Configuration menu - View commit details
-
Copy full SHA for 52c094b - Browse repository at this point
Copy the full SHA 52c094bView commit details -
Connectivity: port code from DotNetEssentials
Implement Connectivity for Gtk platform by porting code from nblockchain/DotNetEssentials.
Configuration menu - View commit details
-
Copy full SHA for b9f1794 - Browse repository at this point
Copy the full SHA b9f1794View commit details -
Core: implemented NavigationViewHandler for Gtk
Implemented NavigationViewHandler for Gtk. Made changes so that NavigationViewHandler is used for NavigationPage in Gtk, instead of generic Page handler. It is incomplete at the moment. Processing of navigation events works, but toolbar is not implemented. Co-authored-by: Parham <parhaamsaremi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 502cc8a - Browse repository at this point
Copy the full SHA 502cc8aView commit details -
GitHubCI,src: move format check from daily to push
In order to have this new CI fragment pass we've had to update many C# files.
Configuration menu - View commit details
-
Copy full SHA for a2efebe - Browse repository at this point
Copy the full SHA a2efebeView commit details -
Core(Gtk): implement AlertManager (lytico#4)
Implement AlertManager for Gtk. Implementation is not complete; alert dialogs and action sheets are implemented, progress bar prompts are not. Also title bar is not shown.
Configuration menu - View commit details
-
Copy full SHA for 1b58dd2 - Browse repository at this point
Copy the full SHA 1b58dd2View commit details -
Core(Gtk): implement visibility in layouts
Layouts in Gtk now react to change in Visibility property.
Configuration menu - View commit details
-
Copy full SHA for c0ab5fb - Browse repository at this point
Copy the full SHA c0ab5fbView commit details
Commits on Mar 13, 2023
-
GitHubCI: use slnf instead of csproj
This way we know exactly all the projects that are being compiled.
Configuration menu - View commit details
-
Copy full SHA for be2239b - Browse repository at this point
Copy the full SHA be2239bView commit details
Commits on Mar 16, 2023
-
Core(Gtk): implement date picker
Made date picker work, ported from [1]. But it gives errors in console and can crash[2] if opened/closed many times. [1] https://github.com/xamarin/Xamarin.Forms/blob/5.0.0/Xamarin.Forms.Platform.GTK/Controls/DatePicker.cs [2] (TODO: file a bug in GtkSharp repo): ``` (GWallet.Frontend.Maui:110296): GLib-GObject-CRITICAL **: 12:14:36.625: g_object_remove_toggle_ref: assertion 'G_IS_OBJECT (object)' failed (GWallet.Frontend.Maui:110296): GLib-GObject-CRITICAL **: 12:14:36.627: g_object_remove_toggle_ref: assertion 'G_IS_OBJECT (object)' failed Marshaling button-press-event signal Exception in Gtk# callback delegate Note: Applications can use GLib.ExceptionManager.UnhandledException to handle the exception. GLib.MissingIntPtrCtorException: Unable to construct instance of type Microsoft.Maui.Platform.DatePickerWindow from native object handle. Instance of managed subclass may have been prematurely disposed. at GLib.ObjectManager.CreateObject(IntPtr raw) at GLib.Object.GetObject(IntPtr o, Boolean owned_ref) at GLib.Value.get_Val() at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data) at GLib.ExceptionManager.RaiseUnhandledException(Exception e, Boolean is_terminal) at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data) at GLib.Application.Run(String program_name, String[] args) at GLib.Application.Run() at Microsoft.Maui.MauiGtkApplication.Launch(EventArgs args) in /home/ubuntu/geewallet-build/geewallet/dependencies/maui/src/Core/src/Platform/Gtk/MauiGtkApplication.cs:line 127 at Microsoft.Maui.MauiGtkApplication.Run(String[] args) in /home/ubuntu/geewallet-build/geewallet/dependencies/maui/src/Core/src/Platform/Gtk/MauiGtkApplication.cs:line 40 at GWallet.Frontend.Maui.Program.main(String[] _args) in /home/ubuntu/geewallet-build/geewallet/src/GWallet.Frontend.Maui/Platforms/Gtk/Program.fs:line 14 ``` Co-authored-by: Parham <parhaamsaremi@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 33aa7d6 - Browse repository at this point
Copy the full SHA 33aa7d6View commit details -
Core(Gtk): fix DatePickerWindow crash
Fix potential exception if DatePicker is used many times quickly: ``` (GWallet.Frontend.Maui:110296): GLib-GObject-CRITICAL **: 12:14:36.625: g_object_remove_toggle_ref: assertion 'G_IS_OBJECT (object)' failed (GWallet.Frontend.Maui:110296): GLib-GObject-CRITICAL **: 12:14:36.627: g_object_remove_toggle_ref: assertion 'G_IS_OBJECT (object)' failed Marshaling button-press-event signal Exception in Gtk# callback delegate Note: Applications can use GLib.ExceptionManager.UnhandledException to handle the exception. GLib.MissingIntPtrCtorException: Unable to construct instance of type Microsoft.Maui.Platform.DatePickerWindow from native object handle. Instance of managed subclass may have been prematurely disposed. at GLib.ObjectManager.CreateObject(IntPtr raw) at GLib.Object.GetObject(IntPtr o, Boolean owned_ref) at GLib.Value.get_Val() at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data) at GLib.ExceptionManager.RaiseUnhandledException(Exception e, Boolean is_terminal) at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data) at GLib.Application.Run(String program_name, String[] args) at GLib.Application.Run() at Microsoft.Maui.MauiGtkApplication.Launch(EventArgs args) in /home/ubuntu/geewallet-build/geewallet/dependencies/maui/src/Core/src/Platform/Gtk/MauiGtkApplication.cs:line 127 at Microsoft.Maui.MauiGtkApplication.Run(String[] args) in /home/ubuntu/geewallet-build/geewallet/dependencies/maui/src/Core/src/Platform/Gtk/MauiGtkApplication.cs:line 40 at GWallet.Frontend.Maui.Program.main(String[] _args) in /home/ubuntu/geewallet-build/geewallet/src/GWallet.Frontend.Maui/Platforms/Gtk/Program.fs:line 14 ``` By using Hide instead of Destroy.
Configuration menu - View commit details
-
Copy full SHA for 7ff3c3a - Browse repository at this point
Copy the full SHA 7ff3c3aView commit details -
Core(Gtk): fix calendar position
Fix position of calendar pop-up when opened more than one time.
Configuration menu - View commit details
-
Copy full SHA for 1dcf7a9 - Browse repository at this point
Copy the full SHA 1dcf7a9View commit details -
Core(Gtk): no excessive OnDateTimeChanged events
Avoid excessive firing of OnDateTimeChanged events when creating DatePickerWindow.
Configuration menu - View commit details
-
Copy full SHA for a1efe23 - Browse repository at this point
Copy the full SHA a1efe23View commit details -
Core(Gtk): update calendar properties
Update calendar properties SelectedDate, MinimumDate, MaximumDate when opening calendar popup when it is already created but hidden.
Configuration menu - View commit details
-
Copy full SHA for fe92c90 - Browse repository at this point
Copy the full SHA fe92c90View commit details -
Core(Gtk): fix datePicker window position
DatePicker window location was wrong when we didn't use x11 GdkBackend. This problem was fixed by setting the TransientFor property. Co-authored-by: webwarrior-ws <reg@webwarrior.ws>
Configuration menu - View commit details
-
Copy full SHA for 0032339 - Browse repository at this point
Copy the full SHA 0032339View commit details -
Core(GTK): fix obsolete method calls in datepicker
Replace deprecated methods. Used Entry icon instead of defining a new button for datepicker arrow. Co-authored-by: webwarrior-ws <reg@webwarrior.ws>
Configuration menu - View commit details
-
Copy full SHA for 8c3d7c2 - Browse repository at this point
Copy the full SHA 8c3d7c2View commit details -
Merge PR lytico#7 from wip/datePicker
Core(Gtk): implement date picker
Configuration menu - View commit details
-
Copy full SHA for 0bc11bb - Browse repository at this point
Copy the full SHA 0bc11bbView commit details -
Core(Gtk): fix setting background color in Button
Fix setting background color for Button. Following advice from https://stackoverflow.com/questions/1706550/gtk-modifying-background-color-of-gtkbutton#comment115871542_41850551
Configuration menu - View commit details
-
Copy full SHA for 97d580e - Browse repository at this point
Copy the full SHA 97d580eView commit details -
Core(Gtk): fix setting of style
Fix setting of style in widgets in certain cases (when widget's CSS path contains spaces).
Configuration menu - View commit details
-
Copy full SHA for f59dd7a - Browse repository at this point
Copy the full SHA f59dd7aView commit details -
Merge PR lytico#10 from webwarrior-ws/fix-button-colors
Core(Gtk): fix button colors.
Configuration menu - View commit details
-
Copy full SHA for 791aad0 - Browse repository at this point
Copy the full SHA 791aad0View commit details
Commits on Mar 29, 2023
-
Controls.Hosting(GTK): mappings for Frame (lytico#11)
Add mappers for BorderColor and CornerRadius for Frame elements so they can now have borders.
Configuration menu - View commit details
-
Copy full SHA for 6079541 - Browse repository at this point
Copy the full SHA 6079541View commit details -
Fix fill in solid shapes like Ellipse or Rectangle.
Configuration menu - View commit details
-
Copy full SHA for 7abe8de - Browse repository at this point
Copy the full SHA 7abe8deView commit details -
Core(Gtk): enable drawing of Path elements
Path elements are now being drawn.
Configuration menu - View commit details
-
Copy full SHA for 33f9edc - Browse repository at this point
Copy the full SHA 33f9edcView commit details -
Core(Gtk): add OnSetImageSource for ImageHandler
Previously, Image class didn't work in maui code and after setting the image nothing would appear.
Configuration menu - View commit details
-
Copy full SHA for 148b52c - Browse repository at this point
Copy the full SHA 148b52cView commit details
Commits on Mar 31, 2023
-
Core(Gtk): fix Visibility bug in WidgetExtenstion
When visibility for image or label (or other views) was set to false, they stayed visible in the application.
Configuration menu - View commit details
-
Copy full SHA for 1610d50 - Browse repository at this point
Copy the full SHA 1610d50View commit details
Commits on Apr 3, 2023
-
Essentials(Gtk): implement Launcher (lytico#15)
Ported Launcher code from DotNetEssentials.
Configuration menu - View commit details
-
Copy full SHA for 8d082ed - Browse repository at this point
Copy the full SHA 8d082edView commit details -
Core,Controls(Gtk): implement tap/click gestures (lytico#14)
Implement tap/click gestures for Gtk. Note that due to the way Gtk works only certain widgets can respond to click events. I changed ContentView to inherit from EventBox, so many elements have this capability, including all layouts. Still many widgets such as label for which adding tap gesture recognizer will have no effect. See https://discourse.gnome.org/t/gtk-widget-mouse-down-event-does-not-seem-to-work/1699.
Configuration menu - View commit details
-
Copy full SHA for 6521d27 - Browse repository at this point
Copy the full SHA 6521d27View commit details
Commits on Apr 5, 2023
-
Implement WidthRequest and HeightRequest mappings for Image.
Configuration menu - View commit details
-
Copy full SHA for 6bb9424 - Browse repository at this point
Copy the full SHA 6bb9424View commit details -
Merge PR lytico#13 from parhamsaremi/fix-image-problems-rebased
Fix image problems for GTK.
Configuration menu - View commit details
-
Copy full SHA for bd1471b - Browse repository at this point
Copy the full SHA bd1471bView commit details
Commits on Apr 19, 2023
-
GithubCI: skip manifest update
Because of new versions of manifest, we got the following error. So by skipping manifest update we make sure that we don't get unwanted updates. ``` Workload installation failed: Failed to install manifest gtksharp.net.sdk.gtk version 3.24.24-rev.87-develop: gtksharp.net.sdk.gtk.manifest-6.0.300::3.24.24-rev.87-develop is not found in NuGet feeds https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-runtime-531f715f/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-3f6c45a2/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-emsdk-3f6c45a2-1/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-eng/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet6/nuget/v3/index.json;https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet7/nuget/v3/index.json;https://pkgs.dev.azure.com/xamarin/public/_packaging/SkiaSharp/nuget/v3/index.json;https://nuget.pkg.github.com/GtkSharp/index.json".. ```
Configuration menu - View commit details
-
Copy full SHA for 40c2ae9 - Browse repository at this point
Copy the full SHA 40c2ae9View commit details
Commits on Apr 27, 2023
-
Sample.Gtk: build SourceGen separately
Build Controls.SourceGen.csproj before building Microsoft.Maui.Gtk.slnf. We have to do this since sometimes when building the Sample.Gtk project, the error below is shown. It's a random error that happens when building the Microsoft.Maui.Gtk.slnf but it doesn't happen in each build attempt. ``` CSC : error CS0006: Metadata file '/home/runner/work/maui/maui/.nuspec/Microsoft.Maui.Controls.SourceGen.dll' could not be found [/home/runner/work/maui/maui/src/Controls/samples/Controls.Sample.Gtk/Controls.Sample.Gtk.csproj] 0 Warning(s) 1 Error(s) ```
Configuration menu - View commit details
-
Copy full SHA for 5a5c95c - Browse repository at this point
Copy the full SHA 5a5c95cView commit details