Add MimbleWimble support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know you have squashed all commits into 1 in order to not have to curate your commit history to have all commits be green. But I prefer a not-all-green commit history for a PR (that I squash into one myself when merging) than just losing all those commits that you had @webwarrior-ws |
What do you propose? To have all the original commits in the PR? |
|
That's exactly what I said. |
|
i.e. ...But I prefer a not-all-green commit history for a PR... |
webwarrior-ws
force-pushed
the
mimblewimble-squashed
branch
from
c702894 to
43a756e
Compare
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
| BigInteger.FromByteArrayUnsigned(arr).Mod(scalarOrder) | ||
|
|
||
| if k0 = BigInteger.Zero then | ||
| failwith "Failure. This happens only with negligible probability." |
There was a problem hiding this comment.
It's extremely unlikely that sha256 hash of some value will be all zeros or exactly scalarOrder.
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
| member self.IsMine = self.AddressIndex <> Coin.UnknownIndex | ||
| member self.HasSpendKey = self.SpendKey.IsSome | ||
|
|
||
| static member Empty = |
There was a problem hiding this comment.
@webwarrior-ws can this be marked as private or internal?
There was a problem hiding this comment.
No, it's used in tests. Unless I duplicate this method in tests.
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
knocte
reviewed
Oct 12, 2023
webwarrior-ws
force-pushed
the
mimblewimble-squashed
branch
from
2259386 to
442179f
Compare
webwarrior-ws
force-pushed
the
mimblewimble-squashed
branch
from
fba0a77 to
490c2ed
Compare
webwarrior-ws
force-pushed
the
mimblewimble-squashed
branch
from
490c2ed to
23f0e1f
Compare
|
@webwarrior-ws I guess this PR needs cleanup (e.g. squashing). But if you add LIP0006 work here, please add it as a separate commit. |
Add types needed for MimbleWimble transactions and implement serialization. Made all MimbleWimble types implement ISerializable and interface and Read static method. Reuse NBitcoin's BitcoinStream for serialization and deserialization, but don't use its IBitcoinSerializable interface because it mixes reading and writing in one method. Added new test project for MimbleWimble tests. Added test for peg-in transaction. Added property-based tests for serialization and deserilaization. Added test that deserilizes transaction generated and serialized by modified litecoin test (see [1]). Added tests for parsing peg-out transaction and MW to MW (HogEx) transaction. [1] https://github.com/litecoin-project/litecoin/blob/5ac781487cc9589131437b23c69829f04002b97e/src/libmw/test/tests/models/tx/Test_Transaction.cpp
webwarrior-ws
force-pushed
the
mimblewimble-squashed
branch
from
490c2ed to
5f5e144
Compare
Add NBitcoin.Secp256k1 library because it has Schnorr signature. As the library requires .netstandard 2.1, make NLitecoin target it instead of 2.0.
Implement construction of range proofs. Added a new test project that does differential tests for zero-knowledge proof components that uses Secp256k1-ZKP.Net library (libsecp256k1 wrapper) as reference. Use Assert.Inconclusive if function is missing in libsecp256k1 on current platform.
Implement transaction builder and add tests for it.
Added Wallet type, which is responsible for key derivation, rewinding of transaction outputs, and storage of rewound outputs (coins), as well as creating transactions using our keychain and spendable coins.
Ported test for key derivation and stealth address generation using KeyChain. Minor code style improvements.
Fixes in Wallet and TransactionBuilder mostly related to public/private spend keys.
Added integration test for Wallet.
Update NBitcoin to version 7.0.13 because older NBitcoin versions can't decode bech32 strings of length > 90, which is needed for MimbleWimble address decoding.
Implemented decoding of MimbleWimble stealth addresses. Added test.
Increase package's version to 0.2.0.
Implement "read-only" keychain, that allows for balance to be checked without knowledge of wallet's seed (which would allow for spending funds), only with private scan key and public spend keys.
Addressed code review comments. Added latest Fsdk package in order to use BetterAssert function.
Fixed transaction deserialization so that it now handles HogEx transactions, which have mweb extension flag but don't contain MW transaction. Added test for this case.
webwarrior-ws
force-pushed
the
mimblewimble-squashed
branch
from
44e944e to
9b278b1
Compare
|
Squashed. CI for all commits is green now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented parsing and creation of MimbleWimble transactions, as well as Wallet type for keeping track of unspent coins. Added tests for implemented functionality.