NOnion.Tests: ignore non-200 status codes

Purpose of our HS browsing tests is to make sure we can connect to the server and just receieving a status code means we are connected so there's no need to make sure the status code is 200, this is especially true because TorHttpClient doesn't handle redirects which causes Unsuccessful- HttpRequestException when there's a redirect.
nblockchain · Aug 2, 2023 · 44cd059 · 44cd059
1 parent 7662941
commit 44cd059
Showing 1 changed file with 21 additions and 3 deletions.
diff --git a/NOnion.Tests/HiddenServicesTests.cs b/NOnion.Tests/HiddenServicesTests.cs
@@ -102,7 +102,16 @@ public async Task BrowseFacebookOverHS()
 
             var client = await TorServiceClient.ConnectAsync(directory, "facebookwkhpilnemxj7asaniu7vnjjbiltxjqhye3mhbshg7kx5tfyd.onion");
             var httpClient = new TorHttpClient(client.GetStream(), "facebookwkhpilnemxj7asaniu7vnjjbiltxjqhye3mhbshg7kx5tfyd.onion");
-            await httpClient.GetAsStringAsync("/", false);
+
+            try
+            {
+                await httpClient.GetAsStringAsync("/", false);
+            }
+            catch (UnsuccessfulHttpRequestException)
+            {
+                // Ignore non-200 Http response status codes
+                // The fact that we are receieving an http response means we are connected
+            }
         }
 
         [Test]
@@ -122,8 +131,17 @@ public async Task BrowseFacebookOverHSWithTLS()
             await sslStream.AuthenticateAsClientAsync(string.Empty, null, SslProtocols.Tls12, false);
 
             var httpClientOverSslStream = new TorHttpClient(sslStream, "www.facebookwkhpilnemxj7asaniu7vnjjbiltxjqhye3mhbshg7kx5tfyd.onion");
-            var facebookResponse = await httpClientOverSslStream.GetAsStringAsync("/", false);
-            Assert.That(facebookResponse.Contains("<html"), "Response from facebook was invalid.");
+
+            try
+            {
+                var facebookResponse = await httpClientOverSslStream.GetAsStringAsync("/", false);
+                Assert.That(facebookResponse.Contains("<html"), "Response from facebook was invalid.");
+            }
+            catch (UnsuccessfulHttpRequestException)
+            {
+                // Ignore non-200 Http response status codes
+                // The fact that we are receieving an http response means we are connected
+            }
         }
 
         [Test]