TorLogger: prevent double initialization

Co-authored-by: Afshin Arani <afshin@arani.dev>

NOnion.Tests/HiddenServicesTests.cs

@@ -24,12 +24,6 @@ namespace NOnion.Tests
 {
     public class HiddenServicesTests
     {
-        [SetUp]
-        public void Init()
-        {
-            TorLogger.Init(TestContext.Progress.WriteLine);
-        }
-
         /* It's possible that the router returned by GetRandomFallbackDirectory or
          * GetRandomRoutersForDirectoryBrowsing be inaccessable so we need to continue
          * retrying if an exceptions happened to make sure the issues are not related

NOnion.Tests/LoggerSetup.cs

@@ -0,0 +1,17 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+using NUnit.Framework;
+
+namespace NOnion.Tests
+{
+    [SetUpFixture]
+    public class LoggerSetup
+    {
+        [OneTimeSetUp]
+        public void Init()
+        {
+            TorLogger.Init(TestContext.Progress.WriteLine);
+        }
+    }
+}

NOnion.Tests/MonohopCircuits.cs

@@ -16,12 +16,6 @@ namespace NOnion.Tests
 {
     public class MonohopCircuits
     {
-        [SetUp]
-        public void Init()
-        {
-            TorLogger.Init(TestContext.Progress.WriteLine);
-        }
-
         /* It's possible that the router returned by GetRandomFallbackDirectory or
          * GetRandomRoutersForDirectoryBrowsing be inaccessable so we need to continue
          * retrying if an exceptions happened to make sure the issues are not related

NOnion.Tests/MultihopCircuits.cs

@@ -11,12 +11,6 @@ namespace NOnion.Tests
 {
     public class MultihopCircuits
     {
-        [SetUp]
-        public void Init()
-        {
-            TorLogger.Init(TestContext.Progress.WriteLine);
-        }
-
         /* It's possible that the router returned by GetRandomFallbackDirectory or
          * GetRandomRoutersForDirectoryBrowsing be inaccessable so we need to continue
          * retrying if an exceptions happened to make sure the issues are not related

NOnion.Tests/OutsideWorldConnectionTest.cs

@@ -12,12 +12,6 @@ namespace NOnion.Tests
 {
     internal class OutsideWorldConnectionTest
     {
-        [SetUp]
-        public void Init()
-        {
-            TorLogger.Init(TestContext.Progress.WriteLine);
-        }
-
         /* It's possible that the router returned by GetRandomFallbackDirectory or
          * GetRandomRoutersForDirectoryBrowsing be inaccessable so we need to continue
          * retrying if an exceptions happened to make sure the issues are not related

NOnion.Tests/TorDirectoryTests.cs

@@ -27,8 +27,6 @@ public void Init()
                     )
                 );
             cachePath.Create();
-
-            TorLogger.Init(TestContext.Progress.WriteLine);
         }
 
         private DirectoryInfo cachePath = null;

NOnion/TorLogger.fs

@@ -6,6 +6,9 @@ module TorLogger =
     let mutable LoggerOpt: Option<Action<string>> = None
 
     let Init(loggingFunc: Action<string>) =
+        if LoggerOpt.IsSome then
+            failwith "TorLogger.Init() called more than once"
+
         LoggerOpt <- Some loggingFunc
 
     let Log(msg: string) =