Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services: ret NOnionException downloadDescriptor #48

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Services: ret NOnionException downloadDescriptor #48

merged 1 commit into from
Nov 10, 2022

Conversation

parhamsaremi
Copy link

Previously returned exception with failwith which returned System.Exception. Now it returns NOnionExceptoin.

@knocte
Copy link
Member

knocte commented Nov 9, 2022

@aarani please review

@knocte
Copy link
Member

knocte commented Nov 9, 2022

From my side, you're not explaining the why in the commit message (adding a link to the bug you're aiming to fix provides the why).

@parhamsaremi
Copy link
Author

From my side, you're not explaining the why in the commit message (adding a link to the bug you're aiming to fix provides the why).

Yup sorry, fixed now.

@knocte
Copy link
Member

knocte commented Nov 9, 2022

Fixes nblockchain/geewallet#181

This statement is false, because even if I merge this PR, it doesn't fix the bug.

@aarani
Copy link
Collaborator

aarani commented Nov 9, 2022

@aarani please review

The code LGTM.

@parhamsaremi
Copy link
Author

Fixes nblockchain/geewallet#181

This statement is false, because even if I merge this PR, it doesn't fix the bug.

I updated the body message and explained the situation.

@knocte
Copy link
Member

knocte commented Nov 9, 2022

but it dosn't fix it. The fix for that problem should be continued on GWallet.

Typo "dosn't" ^ and anyway, you don't need to say it doesn't fix it; it's obvious that GWallet needs to update NOnion dep for that.

@parhamsaremi
Services: ret NOnionException downloadDescriptor
d94453a 
Previously returned exception with failwith which returned
System.Exception. Now it returns NOnionExceptoin. This work
is necessary for fixing [1].

[1] nblockchain/geewallet#181
@parhamsaremi
Copy link
Author

but it dosn't fix it. The fix for that problem should be continued on GWallet.

Typo "dosn't" ^ and anyway, you don't need to say it doesn't fix it; it's obvious that GWallet needs to update NOnion dep for that.

Fixed.

@knocte knocte merged commit 59a6127 into nblockchain:master Nov 10, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parhamsaremi @knocte @aarani