Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network: hide HS methods from public API #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aarani
Copy link
Collaborator

@aarani aarani commented May 3, 2023

There are some HS-related methods in TorStream and TorCircuit which are not supposed to be called by users directly (they should be used by TorServiceClient and TorServiceHost), this commit marks them as internal.

There are some HS-related methods in TorStream
and TorCircuit which are not supposed to be called
by users directly (they should be used by TorServiceClient
and TorServiceHost), this commit marks them as internal.
@aarani aarani mentioned this pull request May 3, 2023
@knocte
Copy link
Member

knocte commented Oct 21, 2023

LGTM

@aarani
Copy link
Collaborator Author

aarani commented Oct 21, 2023

LGTM

Merging can be performed automatically with 1 approving review.

Mark the PR as reviewed so I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants