Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network,Directory,Http: naming scheme for async #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

webwarrior-ws
Copy link

Rename TorStream, TorCircuit, TorGuard, TorDirectory, and TorHttpClient methods according to the following scheme:
for method is called Foo
Foo() should return 'T
FooAsync() should return Task<'T>
AsyncFoo() should return Async<'T>.

Rename TorStream, TorCircuit, TorGuard, TorDirectory,
and TorHttpClient methods according to the following scheme:
for method is called Foo
Foo() should return 'T
FooAsync() should return Task<'T>
AsyncFoo() should return Async<'T>.
@aarani
Copy link
Collaborator

aarani commented May 31, 2023

Argh, tests failed due to unrelated issues, I haven't seen a flaky test in a while, re-running now.

I added the failing run to #46

@aarani aarani mentioned this pull request May 31, 2023
@aarani
Copy link
Collaborator

aarani commented Oct 21, 2023

knocte approved these changes 3 minutes ago

I'm gonna wait on merging this so I can do a thorough review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants