FileConventions: fix the function

Fix DetectUnpinnedNpmPackageInstallVersions function.
nblockchain · Jul 13, 2023 · 61ed51e · 61ed51e
1 parent 08e1045
commit 61ed51e
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/FileConventions/Library.fs b/src/FileConventions/Library.fs
@@ -74,10 +74,15 @@ let DetectUnpinnedNpmPackageInstallVersions(fileInfo: FileInfo) =
     let npmPackageInstallRegex =
         Regex("npm\\s+install\\s+", RegexOptions.Compiled)
 
+    let npmPackageVersionRegex =
+        Regex("@\\d+\\.\\d+\\.\\d+", RegexOptions.Compiled)
+
     let unpinnedNpmPackageInstallVersions =
         fileLines
-        |> Seq.filter(fun line -> npmPackageInstallRegex.IsMatch line)
-        |> Seq.filter(fun line -> not(line.Contains "@"))
+        |> Seq.filter(fun line ->
+            npmPackageInstallRegex.IsMatch line
+            && npmPackageVersionRegex.IsMatch line |> not
+        )
         |> (fun unpinnedVersions -> Seq.length unpinnedVersions > 0)
 
     unpinnedNpmPackageInstallVersions