Skip to content

Commit

Permalink
FileConventions.Test: add failing test
Browse files Browse the repository at this point in the history
Add failing test for detecting unpinned version in npm package
installations.
  • Loading branch information
tehraninasab committed Jul 6, 2023
1 parent 1217c08 commit ef3e8bb
Show file tree
Hide file tree
Showing 3 changed files with 31 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
name: CI

on: [push, pull_request]

jobs:
file-conventions:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: Install prettier without specifying its version
run: npm install prettier
16 changes: 16 additions & 0 deletions src/FileConventions.Test/FileConventions.Test.fs
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,22 @@ let DetectUnpinnedDotnetToolInstallVersions2() =
)


[<Test>]
let DetectUnpinnedNpmPackageInstallVersions1() =
let fileInfo =
(FileInfo(
Path.Combine(
dummyFilesDirectory.FullName,
"DummyCIWithUnpinnedNpmPackageInstallVersion.yml"
)
))

Assert.That(
DetectUnpinnedNpmPackageInstallVersions fileInfo,
Is.EqualTo true
)


[<Test>]
let DetectAsteriskInPackageReferenceItems1() =
let fileInfo =
Expand Down
4 changes: 4 additions & 0 deletions src/FileConventions/Library.fs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@ let DetectUnpinnedDotnetToolInstallVersions(fileInfo: FileInfo) =

unpinnedDotnetToolInstallVersions

let DetectUnpinnedNpmPackageInstallVersions(fileInfo: FileInfo) =
printfn "File Path: %s" fileInfo.FullName
false

let DetectAsteriskInPackageReferenceItems(fileInfo: FileInfo) =
assert (fileInfo.FullName.EndsWith "proj")
use streamReader = new StreamReader(fileInfo.FullName)
Expand Down

0 comments on commit ef3e8bb

Please sign in to comment.