Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkflowGuidelines: add exception parsing #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aarani
Copy link
Contributor

@aarani aarani commented Apr 25, 2023

No description provided.

@knocte
Copy link
Member

knocte commented May 23, 2023

@aarani CI is broken. I know the failure msg is misleading, but that is already fixed in master. So please rebase first and then you will get a more understandable message.

@@ -78,6 +78,46 @@

let savedData = System.IO.File.ReadAllText saveFilePath.FullName
```
* Avoid applying logic based on exception's message:

Exception messages (even in stable libraries/softwares) are subject to change, applying logic based on the `Message` or `StackTrace` can cause hard-to-debug problems when updating your dependencies or in case of .NET even your framework version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aarani "in case of .NET even your framework version"? I can't parse that, please fix; also can you update this PR to follow this please: b07ea57

()
with
| :? PostgresException as ex when
isDuplicatePrimaryKeyError ex ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aarani wrong indentation length

@knocte
Copy link
Member

knocte commented May 27, 2023

Also let's rebase this PR please. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants