Skip to content

Commit

Permalink
fsxc: default to warnings as errors
Browse files Browse the repository at this point in the history
Fixes #32
  • Loading branch information
knocte committed Aug 18, 2023
1 parent dea8023 commit db7ce14
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion ReadMe.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ THIS REPO IS FACING A COMPLETE OVERHAUL/REVAMP/RENOVATION IN ORDER TO SUPPORT .N
Unfinished tasks so far:
* Revamp this ReadMe.md file to remove any mentions to Mono or the legacy .NET4.x framework.
* Remove legacy framework support (so that build system can converge into .fsx files instead of autotools in Unix + fsx in Windows).
* Make fsxc always enable warnAsError and fsx always disable it.
* Allow fsxc && fsx disable warnAsError (via --w flag? or --ignore-warnings).
* After doing the above, make both fsx and fsxc always enable warnAsError for the FS0020 warning described in https://stackoverflow.com/questions/38202685/fsx-script-ignoring-a-function-call-when-i-add-a-parameter-to-it
* Try creating VMs for CI that uninstall .NETCore/.NET6 completely (not just the dotnet executable removal hack), to make sure legacy framework build still works there.
* Try creating VMs for CI that uninstall Mono/.NET4.x completey (e.g. for macOS see: https://github.com/mono/website/commit/490797429d4b92584394292ff69fbdc0eb002948 )
Expand Down
3 changes: 3 additions & 0 deletions fsxc/Fsxc.fs
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,9 @@ let fsi = { CommandLineArgs = System.Environment.GetCommandLineArgs() }
<AppendTargetFrameworkToOutputPath>false</AppendTargetFrameworkToOutputPath>
</PropertyGroup>
<PropertyGroup>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
</PropertyGroup>
"""

let initialProjectContents = initialProjectContents
Expand Down

0 comments on commit db7ce14

Please sign in to comment.