Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsx -k would run the script #37

Open
knocte opened this issue Aug 25, 2023 · 1 comment
Open

fsx -k would run the script #37

knocte opened this issue Aug 25, 2023 · 1 comment

Comments

@knocte
Copy link
Member

knocte commented Aug 25, 2023 •
edited
Loading

The -k flag was meant to be only for fsxc (not fsx) program, but we're showing it in the fsx case, and in that case it's not doing what it says (it should just compile and not run).
@knocte
Copy link
Member Author

knocte commented Aug 26, 2023

This bug actually only happens in Unix (macOS+Linux) and only when not being installed as a dotnet tool. Why? Because in those cases launcher.sh is used (instead of fsx.fsproj).

knocte added a commit that referenced this issue Aug 26, 2023
@knocte
fsx,fsxc: deprecate --check/-k flag
2d86bd8 
In the cases where launcher.sh is used (instead of fsx.fsproj),
the -k flag was being passed to fsxc successfully, but then the
script would be run. As fixing this would be a bit messy (would
need lots of bash hacks in the launcher), let's rather
deprecate it; and if someone needs to only compile the script,
they can call fsxc directly (which is what we advice in the
deprecation error message).

Fixes #37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@knocte