fsx: fix regression that made fsxc misbehave #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
force-pushed
the
wip/fixRegression
branch
from
759efa6
to
da9b0c0
Compare
In a geewallet's PR[1] I bisected the problem to this commit: dd66eb3. So I'm basically reverting that commit here, but I still don't understand why it would cause such a regression. The problem is that fsxc is not able to compile anymore certain scripts and spits some errors that look to be warnings, such as: ``` Error: D:\a\geewallet\geewallet\scripts\bin\downloadUbuntuDeps.fsx.fs(14,1): error FS0020: The result of this expression has type 'int' and is implicitly ignored. Consider using 'ignore' to discard this value explicitly, e.g. 'expr |> ignore', or 'let' to bind the result to a name, e.g. 'let result = expr'. [D:\a\geewallet\geewallet\scripts\bin\downloadUbuntuDeps.fsx.fsproj] ``` [1] nblockchain/geewallet#289
knocte
force-pushed
the
wip/fixRegression
branch
from
da9b0c0
to
8891a9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a geewallet's PR[1] I bisected the problem to this commit: dd66eb3.
So I'm basically reverting that commit here, but I still don't understand why it would cause such a regression. The problem is that fsxc is not able to compile anymore certain scripts and spits some errors that look to be warnings, such as:
[1] nblockchain/geewallet#289