Fix line numbers once and for all #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous fixes for line numbers were introducing empty commented lines. This refactoring allows the lines to actually have the real content they were carrying, but commented out.
There were still some issues with line numbers when reporting errors so I discovered that in some cases we were swallowing some lines instead of generating LineKind.Normal or .Commented for them.
To be reverted temporarily, this commit just prints the F# autogenerated sources for debugging purposes.
This reverts commit a8662ee because it was actually duplicating the line (these actions were already being printed as a comment).
The last issue with bad line numbers reported is our need to inject this fsi stub. Let's at least make it as small as possible.
The bin folder could be extracted anyway from the .Directory property of the returned FileInfo instance.
Tiny DRY-respect improvement.
This way we will not add 3 extra lines to the beginning of the file, which would make line numbers to be off in case of errors.
This reverts commit 0c2150c because we don't need the debug output anymore.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.