Skip to content

Commit

Permalink
scripts/make: ignore unitTests warns if legacy
Browse files Browse the repository at this point in the history
Somehow, unit tests started to throw strings to StdErr (like
'WARNING: The runtime version supported by this application
is unavailable.') while using dotnet6 it doesn't happen so
we ignore the warnings only if running in legacy mode.

This should fix CI after the last merge.
  • Loading branch information
knocte committed Aug 1, 2023
1 parent e4dfea9 commit 7dfebde
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion scripts/make.fsx
Original file line number Diff line number Diff line change
Expand Up @@ -433,8 +433,17 @@ match maybeTarget with
}
#endif

Process.Execute(runnerCommand, Echo.All).UnwrapDefault()
let procResult = Process.Execute(runnerCommand, Echo.All)
#if !LEGACY_FRAMEWORK
procResult.UnwrapDefault()
|> ignore<string>
#else // in legacy mode, warnings (output to StdErr) happen even if exitCode=0
match procResult with
| ProcessResultState.Error (_, _) ->
failwith "Unit tests failed ^"
| _ ->
()
#endif

| Some("install") ->
let buildConfig = BinaryConfig.Release
Expand Down

0 comments on commit 7dfebde

Please sign in to comment.