Wip/hoop chart

[webwarrior-ws]

Addresses #172 (Better design for cheese chart (so that text is inside it))

[knocte]

@webwarrior-ws good work! Can you enable GitHubActions in your fork please?

[knocte]

@webwarrior-ws actually let's have the same text as the old label: Total Assets:\n

[webwarrior-ws]

Changed label text. CI job failure seems to be unrelated.

[knocte]

CI job failure seems to be unrelated.

True, it was unrelated, but do you mind rebasing your PR? I fixed the CI issue in wip/hoopChart branch.

[webwarrior-ws]

CI job failure seems to be unrelated.

True, it was unrelated, but do you mind rebasing your PR? I fixed the CI issue in wip/hoopChart branch.

I must have done something wrong, because now I can't push:

Pushing to https://github.com/webwarrior-ws/geewallet
To https://github.com/webwarrior-ws/geewallet
! [remote rejected] wip/hoopChart -> wip/hoopChart (refusing to allow an OAuth App to create or update workflow > .github/workflows/CI.yml without workflow scope)
error: failed to push some refs to 'https://github.com/webwarrior-ws/geewallet'

[knocte]

Did you forget the flag --force?

[knocte]

If that doesn't do it; it seems it's the way you cloned your fork? I recommend you to use SSH, not weird OAuth stuff.

[webwarrior-ws]

OK, now with SSH it worked

[knocte]

I said rebase, not merge :(

When rebasing, there should not be any merge commits on top of your branch.

[webwarrior-ws]

I said rebase, not merge :(

When rebasing, there should not be any merge commits on top of your branch.

So now what? Do I checkout or reset to latest commit that is not mine?

[knocte]

IMO you should first delete your branch locally, then checkout commit 9e70c43 and create a new branch from it (same name as the one that this PR is targetting), then cherry-pick your commits from github, then push with --force.

[knocte]

Finally, I had time to test it today (sorry, yesterday I was in the eye-doctor and they gave me something that made my sight blurry).

Code-wise, the proposed PR looks fine; integration seems clean. But I have this rendering problem:

As you can see, the circle is too big, and causes the currency frames to need scrolling. Ideally the circle shouldn't be rendered as big and everything should fit. Do you know if this is easy to fix?

[webwarrior-ws]

Finally, I had time to test it today (sorry, yesterday I was in the eye-doctor and they gave me something that made my sight blurry).

Code-wise, the proposed PR looks fine; integration seems clean. But I have this rendering problem:

As you can see, the circle is too big, and causes the currency frames to need scrolling. Ideally the circle shouldn't be rendered as big and everything should fit. Do you know if this is easy to fix?

Probably not.
In order to do that, shapes that make up hoop chart should resize to fill the container. And honestly I don't know how shapes and paths in Xamarin.Froms work.
Also the chart can't be allowed to get too small, because label might overlap with the shapes.

[knocte]

Also the chart can't be allowed to get too small, because label might overlap with the shapes.

Exactly! But the idea is that the circle only gets big when it needs to (because of a big label). In the case of the screenshot, the amount is not very long, so the circle should not need to be that big.

[knocte]

Superseded by https://gitlab.com/nblockchain/geewallet/-/merge_requests/141