GithubCI: upgrade actions to latest version #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
force-pushed
the
master
branch
2 times, most recently
from
1a3be72
to
265b103
Compare
aarani
force-pushed
the
ciUpgrade
branch
2 times, most recently
from
e174e79
to
456d104
Compare
|
Are you sure DEBIAN_FRONTEND is needed when installing git? |
|
You're missing the why in the commit msg. |
Installing git before checkout was necessary to prevent this error when git wants to interact with the checked out repo (Probably because it's downloaded using Github's REST API): ``` fatal: not a git repository (or any parent up to mount point /) ``` Installing git before checkout also removes the problem with using submodule parameter in checkout action so the comments we had are no longer applicable. This was done to fix errors we had with downloading actions [1]. [1] nblockchain#224 (comment)
|
The why should be the first thing in the commit message body, not the last thing. |
|
Also, PR description and commit msg body should match, given that there's only 1 commit. |
knocte
force-pushed
the
master
branch
2 times, most recently
from
b841302
to
ccb1641
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing git before checkout was necessary to prevent this error when git wants to interact with the checked out repo (Probably because it's downloaded using
Github's REST API):
Installing git before checkout also removes the problem with using submodule parameter in checkout action so the comments we had are no longer applicable.