Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: upload the snap & snap_beta binaries to the GitHub release #255

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Mersho
Copy link
Contributor

@Mersho Mersho commented Feb 22, 2024

No description provided.

@knocte
Copy link
Member

knocte commented Feb 22, 2024

@Mersho I guess you tested this with a tag push in your fork, show me the commit of your fork that achieves this?

@Mersho
Copy link
Contributor Author

Mersho commented Feb 22, 2024

@Mersho I guess you tested this with a tag push in your fork, show me the commit of your fork that achieves this?

here is the commit:

Mersho@ce7c330

and the tag:

https://github.com/Mersho/geewallet/tree/0.7.433.0

@knocte
Copy link
Member

knocte commented Feb 22, 2024

Arghhh I see you already gave this info in the github issue, nevermind.

I realised I want to have this process a bit different than RIM, please make it create the release only if the snap upload succeeded. My bad.

@Mersho Mersho force-pushed the GHReleaseBinaryUpload branch 2 times, most recently from f35d0ec to 9fd4f82 Compare February 22, 2024 09:40
Modified the `needs` context to access `upload_url` within the
`snap_pkg` job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants