Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend.XF.GTK: fix currency colors on GTK #259

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mersho
Copy link
Contributor

@Mersho Mersho commented Feb 29, 2024

Fix currency color indicator on GTK which was not showing up. To address this, we double its width when the platform is GTK.

@knocte
Copy link
Member

knocte commented Mar 1, 2024

Please compare the scope you used here and the scope you used in PR257, you already forgot our conventions?

Fix currency color indicator on GTK which was not showing up.
To address this, we double its width when the platform is GTK.

Co-authored-by: webwarrior <reg@webwarrior.ws>
@Mersho Mersho changed the title GWallet.Frontend.XF: fix currency colors on GTK Frontend.XF.GTK: fix currency colors on GTK Mar 4, 2024
@knocte
Copy link
Member

knocte commented Mar 4, 2024

Fix currency color indicator on GTK which was not showing up

Actually, I just tested geewallet v0.7.430.0 in Ubuntu 22.04.3 and I see the colours:

Screenshot 2024-03-04 at 11 25 56 PM

So please tell me how did you test this? and what version of ubuntu

@Mersho
Copy link
Contributor Author

Mersho commented Mar 5, 2024

So please tell me how did you test this? and what version of ubuntu

I tested geewallet v0.7.431.0 in ubuntu 22.04 LTS by installing the CI-uploaded snap artifact from the master branch.

@knocte
Copy link
Member

knocte commented Mar 5, 2024

Show me a screenshot of that.

@Mersho
Copy link
Contributor Author

Mersho commented Mar 5, 2024

I also tested the v0.7.430.0 right now:

image

@knocte
Copy link
Member

knocte commented Mar 5, 2024

I dont understand that screenshot, do you have 1 LTC, 1 ETH, 1 ETC....? The configuration flag that changes balances like that can only be used when compiling your own version of snap, so I AM SURE YOU ARE NOT TESTING 0.7.430.0!!!!

@Mersho
Copy link
Contributor Author

Mersho commented Mar 5, 2024

Here is the another screenshot of geewallet 0.7.430.0 downloaded from nblockchain/geewallet:

image

@knocte
Copy link
Member

knocte commented Mar 5, 2024

I dont reproduce that bug. Please download Ubuntu 22.04.3 while you're working on other things.

@Mersho
Copy link
Contributor Author

Mersho commented Mar 5, 2024

I dont reproduce that bug. Please download Ubuntu 22.04.3 while you're working on other things.

results is same on Ubuntu 22.04.3:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants