Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI,make.fsx: upload a nuget package #266

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

CI,make.fsx: upload a nuget package #266

wants to merge 4 commits into from

Commits on Mar 8, 2024

  1. Configuration menu
    Copy the full SHA
    7eba876 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. CI,make.fsx: use --native-segwit for dotnet pack

    We use beta version because we use NativeSegwit (0.9 instead of
    0.7, like the beta snap).
    knocte committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    d33fa0b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4488d66 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. scripts/make.fsx: gen normal nupkg & prerelease

    This way we catch potential issues with the non-prerelease nuget
    package before the git tag is pushed.
    
    For example, the following warning:
    
    ```
    /usr/lib/dotnet/sdk/6.0.127/Sdks/NuGet.Build.Tasks.Pack/build/NuGet.Build.Tasks.Pack.targets(221,5): error NU5104: A stable release of a package should not have a prerelease dependency. Either modify the version spec of
    dependency "Fsdk [0.6.0--date20230530-1155.git-3bb8d08, )" or update the version field in the nuspec. [/__w/geewallet/geewallet/src/GWallet.Backend/GWallet.Backend.fsproj]
    ```
    
    So let's enable 'warnaserror' in the 'dotnet pack' command
    if the version to pack is even (e.g. 0.8) and ignore the
    warning for now if it's odd (e.g. 0.7) like it currently
    happens. Because even numbers map to "stableness" and odd
    numbers to the opposite.
    knocte committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    c781bee View commit details
    Browse the repository at this point in the history