Backend: handle null response from Eth server #287
Merged
Commits on Sep 2, 2024
-
Backend: handle null response from Eth server
Introduce AbnormalNullValueInJsonResponseException type and raise it when response for balance request for Ethereum returns json with "result" field value of `null`. This way server will be marked as faulty instead of crashing the application. Fixes nblockchain#282
-
Backend: handle other Eth server null responses
Raise WeirdNullResponseException on all possible null responses or responses that contain null value from Ethereum servers.
-
Backend/Ether: handle/retry RPC error -39000
Add code -39000 (UnparsableResponseType) to RpcErrorCode enum and process it since this error was encountered during integration testing.
-
Backend/Ether: handle/retry HTTP error 408
Handle/retry HTTP error 408 (request timeout) in error handling code (raise ServerTimedOutException).
-
Backend/Ether: refactor null checks
Make all null checks use isNull function as it's the most reliable way to test if value is null.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.