modify.F: fix bug overwriting crucial parameters from comm.1 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- force N from comm.1 on restart. - Check for auto-adjustment settings KZ(16) and KZ(17) and conditionally restore RMIN, DTMIN, ECLOSE, ETAI, ETAR and ETAU from comm.1 file. - moved restart parameters WRITE statement below restore comm.1 values for correct display of restart parameters.
|
Thanks Uli for finding and fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify.F containsa bug overwriting N from the namelist input.
This leads to errors if a runs is continued, but N has changed during the run (escapers, binaries, ...).
KZ(16) & KZ(17) allow auto-adjustment of values which are overwritten by the namelist input on reruns as well.
This MR changes in modify.F:
conditionally restore RMIN, DTMIN, ECLOSE, ETAI, ETAR and ETAU from
comm.1 file.
for correct display of restart parameters.