Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various ESM-related updates #185

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Various ESM-related updates #185

merged 3 commits into from
Dec 16, 2024

Conversation

ncalteen
Copy link
Owner

No description provided.

@ncalteen ncalteen requested a review from Copilot December 16, 2024 20:04
@ncalteen ncalteen self-assigned this Dec 16, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 28 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • .eslintrc.yml: Language not supported
  • .prettierignore: Language not supported
  • CODEOWNERS: Language not supported
  • package.json: Language not supported
  • fixtures/octokit.ts: Evaluated as low risk
  • fixtures/exec.ts: Evaluated as low risk
  • fixtures/octokit-graphql.ts: Evaluated as low risk
  • src/utils/parse-branch-policy.ts: Evaluated as low risk
  • tests/create-regex.test.ts: Evaluated as low risk
  • src/index.ts: Evaluated as low risk
  • tests/index.test.ts: Evaluated as low risk
  • src/utils/create-regex.ts: Evaluated as low risk
  • action.yml: Evaluated as low risk
  • .prettierrc.yml: Evaluated as low risk
  • .yaml-lint.yml: Evaluated as low risk
Comments suppressed due to low confidence (2)

fixtures/core.ts:1

  • The import alias 'core' is used ambiguously here. Consider renaming it to 'ActionsCore' or another distinct name to avoid potential confusion with other 'core' modules.
import type * as core from '@actions/core'

jest.config.ts:32

  • The Jest configuration references 'tsconfig.eslint.json' which is typically used for linting. Ensure this is the intended TypeScript configuration for Jest tests or consider using a dedicated 'tsconfig.jest.json' to avoid potential configuration conflicts.
tsconfig: 'tsconfig.eslint.json',

Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more

sourceType: 'module',

parserOptions: {
project: ['tsconfig.eslint.json'],
Copy link
Preview

Copilot AI Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'project' option should be an absolute path to the tsconfig file. Use path.resolve(__dirname, 'tsconfig.eslint.json') to ensure the correct path is used.

Suggested change
project: ['tsconfig.eslint.json'],
project: [path.resolve(__dirname, 'tsconfig.eslint.json')],

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 5 0 0.07s
✅ JSON jsonlint 7 0 0.22s
✅ JSON prettier 7 0 1.4s
✅ JSON v8r 7 0 23.37s
✅ MARKDOWN markdownlint 2 0 0.67s
✅ MARKDOWN markdown-link-check 2 0 1.9s
✅ REPOSITORY checkov yes no 15.95s
✅ REPOSITORY gitleaks yes no 1.06s
✅ REPOSITORY git_diff yes no 0.11s
❌ REPOSITORY grype yes 3 15.06s
✅ REPOSITORY secretlint yes no 1.23s
✅ REPOSITORY trivy yes no 9.23s
✅ REPOSITORY trivy-sbom yes no 0.58s
✅ REPOSITORY trufflehog yes no 13.49s
✅ TYPESCRIPT prettier 9 0 1.44s
✅ YAML prettier 13 0 1.03s
✅ YAML v8r 13 0 12.08s
✅ YAML yamllint 13 0 0.69s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@ncalteen ncalteen merged commit 421236b into main Dec 16, 2024
4 of 5 checks passed
@ncalteen ncalteen deleted the ncalteen/esm branch December 16, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant