-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various ESM-related updates #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 13 out of 28 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- .eslintrc.yml: Language not supported
- .prettierignore: Language not supported
- CODEOWNERS: Language not supported
- package.json: Language not supported
- fixtures/octokit.ts: Evaluated as low risk
- fixtures/exec.ts: Evaluated as low risk
- fixtures/octokit-graphql.ts: Evaluated as low risk
- src/utils/parse-branch-policy.ts: Evaluated as low risk
- tests/create-regex.test.ts: Evaluated as low risk
- src/index.ts: Evaluated as low risk
- tests/index.test.ts: Evaluated as low risk
- src/utils/create-regex.ts: Evaluated as low risk
- action.yml: Evaluated as low risk
- .prettierrc.yml: Evaluated as low risk
- .yaml-lint.yml: Evaluated as low risk
Comments suppressed due to low confidence (2)
fixtures/core.ts:1
- The import alias 'core' is used ambiguously here. Consider renaming it to 'ActionsCore' or another distinct name to avoid potential confusion with other 'core' modules.
import type * as core from '@actions/core'
jest.config.ts:32
- The Jest configuration references 'tsconfig.eslint.json' which is typically used for linting. Ensure this is the intended TypeScript configuration for Jest tests or consider using a dedicated 'tsconfig.jest.json' to avoid potential configuration conflicts.
tsconfig: 'tsconfig.eslint.json',
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
sourceType: 'module', | ||
|
||
parserOptions: { | ||
project: ['tsconfig.eslint.json'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'project' option should be an absolute path to the tsconfig file. Use path.resolve(__dirname, 'tsconfig.eslint.json') to ensure the correct path is used.
project: ['tsconfig.eslint.json'], | |
project: [path.resolve(__dirname, 'tsconfig.eslint.json')], |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
No description provided.