Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub workflow #156

Merged
merged 6 commits into from
Feb 14, 2024
Merged

Conversation

iarekk
Copy link
Contributor

@iarekk iarekk commented Feb 12, 2024

Several changes:

  1. Add elixir 1.16.x / OTP 26.2 to the matrix.
  2. Upgrade credo to 1.7.4.
    Reason: Credo 1.7.0 issues a huge number of warnings about itself when compiled with Elixir 1.6.x, update to 1.7.4 fixes it. Some discussion in the Credo repo here: Be explicit about steps to avoid warnings rrrene/credo#1085
  3. Address the newly-appeared credo warnings, all of which had the following structure:
    ┃ [R] ↗ Predicate function names should not start with 'is', and should end in a question mark.
    ┃       lib/sobelow/utils.ex:10:7 #(Sobelow.Utils.is_router?)
    
    The change is to rename functions such as is_router? to router?

@iarekk
Copy link
Contributor Author

iarekk commented Feb 12, 2024

Potentially this fixes #152. Happy to break down the PR into smaller chunks if needed!

@iarekk
Copy link
Contributor Author

iarekk commented Feb 12, 2024

https://hexdocs.pm/credo/Credo.Check.Readability.PredicateFunctionNames.html and this is the new Credo check that was breaking the builds after upgrading to 1.7.4

@houllette
Copy link
Collaborator

Hey @iarekk - thank you so much for this QoL PR, really appreciate the assistance!

This is a pretty sizable update, so your dedication to fixing all the credo warnings is really awesome - normally I'd prefer to break this PR up a bit (one for the GitHub Action change, one for the credo bump), but I think it makes sense in this case plus the work is already done and all working together harmoniously / passing checks. So we're good to go here!

@houllette houllette linked an issue Feb 14, 2024 that may be closed by this pull request
@houllette houllette merged commit 6c63d3c into nccgroup:master Feb 14, 2024
10 checks passed
@iarekk
Copy link
Contributor Author

iarekk commented Feb 14, 2024

Thank you @houllette! I'm very happy to help the project – and will definitely keep the PRs smaller nex time 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and fix warnings for new Elixir version
2 participants