Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google sublocality should be city #243

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Google sublocality should be city #243

wants to merge 2 commits into from

Conversation

codemau5
Copy link

@codemau5 codemau5 commented Jan 3, 2018

Google geocodes many addresses without locality, but with sublocality.
therefore i found that if no locality exists, the sublocality should be the city.

@ruscon
Copy link
Contributor

ruscon commented Feb 16, 2019

Examples
https://github.com/alexreisner/geocoder/blob/master/lib/geocoder/results/google.rb#L20-L30
and
https://github.com/DenisCarriere/geocoder/blob/master/geocoder/google.py#L97-L103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codemau5 @ruscon