Review of MAE tutorial #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I modified the branch following our discussion (verbal review). I don't know why the first cell is numbered "15" or how to hide (most of) the help notes. We could just comment that out or add "read the help notes" to the final cell of suggested next steps. |
… default, but it is easy to access if wanted
tennlee
added a commit
that referenced
this pull request
Jan 19, 2024
* First review and extension * Round 2 for MAE tutorial following verbal feedback from Tennessee * Slightly modify the tutorial so that the help message is not shown by default, but it is easy to access if wanted --------- Co-authored-by: Tennessee Leeuwenburg <tennessee.leeuwenburg@bom.gov.au>
tennlee
added a commit
that referenced
this pull request
Feb 13, 2024
* First review and extension * Round 2 for MAE tutorial following verbal feedback from Tennessee * Slightly modify the tutorial so that the help message is not shown by default, but it is easy to access if wanted --------- Co-authored-by: Tennessee Leeuwenburg <tennessee.leeuwenburg@bom.gov.au>
tennlee
added a commit
that referenced
this pull request
Feb 13, 2024
* First review and extension * Round 2 for MAE tutorial following verbal feedback from Tennessee * Slightly modify the tutorial so that the help message is not shown by default, but it is easy to access if wanted --------- Co-authored-by: Tennessee Leeuwenburg <tennessee.leeuwenburg@bom.gov.au>
tennlee
added a commit
that referenced
this pull request
Feb 14, 2024
* feat: new flip flop tutorial notebook * Updated markdown * Improved citation syntax somewhat with newlines and italics to demarcate things * Review of MAE tutorial (#116) * First review and extension Co-authored-by: Tennessee Leeuwenburg <tennessee.leeuwenburg@bom.gov.au> * Update contributing.md Signed-off-by: tennlee <134973832+tennlee@users.noreply.github.com> * feat: add proportion exceeding wrapper for flip flop index (#120) * feat: add proportion exceeding wrapper for flip flop index * minor updates to flipflop proportion exceeding --------- Co-authored-by: Nicholas Loveday <nicholasloveday@gmail.com> * MSE tutorial reviewed by Deryn. * RMSE tutorial reviewed by Deryn * Tidy of MAE, MSE and RMSE tutorials (#136) * Split first cell into two * Added a semi-colon to a markdown cell * Removed one unused variable * Added a plot to flip-flop tutorial * Updated graph labels --------- Signed-off-by: tennlee <134973832+tennlee@users.noreply.github.com> Co-authored-by: aidanjgriffiths <aidanjames.g@gmail.com> Co-authored-by: Tennessee Leeuwenburg <tennessee.leeuwenburg@bom.gov.au> Co-authored-by: tennlee <134973832+tennlee@users.noreply.github.com> Co-authored-by: Aidan Griffiths <58012338+aidanjgriffiths@users.noreply.github.com> Co-authored-by: Nicholas Loveday <nicholasloveday@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, I reviewed the MAE tutorial. I chose to rewrite sections to be explicit with my suggestions.
I have left a few "TO DO" comments at the end which are suggestions I haven't acted on.
Have a look and provide me with some feedback. Act on the "TO DO" if you can.