Eclipse setup & TODOs from diagnostics

ncss-tech · Jul 20, 2022 · d1f5ce8 · d1f5ce8
1 parent 6391a5c
commit d1f5ce8
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 12 deletions.
diff --git a/inst/java/.gitignore b/inst/java/.gitignore
@@ -0,0 +1,3 @@
+/.classpath
+/.project
+/org/
diff --git a/java/.gitignore b/java/.gitignore
@@ -0,0 +1,3 @@
+/.classpath
+/.project
+/org/
diff --git a/java/org/psu/newhall/Newhall.java b/java/org/psu/newhall/Newhall.java
@@ -1,8 +1,5 @@
 package org.psu.newhall;
 import java.io.File;
-import java.util.Arrays;
-import java.util.stream.Stream;
-import java.util.stream.Collectors;
 import org.psu.newhall.sim.*;
 import org.psu.newhall.util.*;
 

diff --git a/java/org/psu/newhall/sim/BASICSimulationModel.java b/java/org/psu/newhall/sim/BASICSimulationModel.java
@@ -191,7 +191,7 @@ public static NewhallResults runSimulation(double[] temperature,
 
 
      double arf = 0.0D;
-     double aev = 0.0D;
+     double aev = 0.0D; // TODO: value not used?
      for (int i2 = 1; i2 <= 12; i2++) {
        arf += precip[i2];
        aev += mpe[i2];
@@ -273,8 +273,8 @@ public static NewhallResults runSimulation(double[] temperature,
      }
 
      int k = 1;
-     int swst = 0;
-     int swfi = 0;
+     int swst = 0; // TODO: not used?
+     int swfi = 0; // TODO: not used?
 
      double[] ntwi = new double[4];
      double[] ntsu = new double[4];
@@ -3075,7 +3075,7 @@ else if (!trr.equalsIgnoreCase("pergelic") && !trr.equalsIgnoreCase("cryic")) {
 
 
      byte[] cc2Bytes = { 7, 0, 7, 0, 7 };
-     String cc2 = new String(cc2Bytes);
+     String cc2 = new String(cc2Bytes); // TODO: value not used?
      int c2 = 0;
 
 
@@ -3152,7 +3152,7 @@ public static NewhallResults runSimulation(NewhallDataset dataset, double waterH
      boolean hasRunAlready = false;
 
 
-     double elevation = dataset.getElevation();
+     double elevation = dataset.getElevation(); // TODO: not used?
      if (!dataset.isMetric())
      {
 /*   30 */       elevation *= 0.305D;
@@ -3411,8 +3411,8 @@ public static NewhallResults runSimulation(NewhallDataset dataset, double waterH
      }
 
      int k = 1;
-     int swst = 0;
-     int swfi = 0;
+     int swst = 0; // TODO: not used?
+     int swfi = 0; // TODO: not used?
 
      double[] ntwi = new double[4];
 /*  290 */     double[] ntsu = new double[4];
@@ -6221,7 +6221,7 @@ else if (!trr.equalsIgnoreCase("pergelic") && !trr.equalsIgnoreCase("cryic")) {
 
 
     byte[] cc2Bytes = { 7, 0, 7, 0, 7 };
-    String cc2 = new String(cc2Bytes);
+    String cc2 = new String(cc2Bytes); // TODO: not used?
     int c2 = 0;
 
     String flxFile = "\"" + dataset.getName() + "\",\"" + dataset.getCountry() + "\"," + dataset.getLatitudeDegrees() + ",";

diff --git a/java/org/psu/newhall/sim/NewhallDatasetMetadata.java b/java/org/psu/newhall/sim/NewhallDatasetMetadata.java
@@ -1,6 +1,5 @@
 package org.psu.newhall.sim;
 
-import java.util.Collections;
 import java.util.List;
 import java.util.ArrayList;