feat: RTL support #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For whatever reason, I'm unable to get the popover anchor to inject the correct Dir instance. It always seems to inject the root Directionality instance, which doesn't support dynamic toggling. For a future PR - Testing can still be done by statically adding `dir="rtl"` to the body.
willshowell
commented
Oct 25, 2017
| /** The text direction of the containing app. */ | ||
| private get _direction(): Direction { | ||
| return this._dir && this._dir.value === 'rtl' ? 'rtl' : 'ltr'; | ||
| } |
There was a problem hiding this comment.
Make private _getDirection()
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the positioning service to properly interpret
xPositionin rtl mode. Previously, a value ofafterwithdir="rtl"would result in the popover opening to the right. It also updates the transform origin.Caveat: I've been struggling to troubleshoot an issue where SatPopoverAnchor does not inject the correct
Dirinstance when using the[dir]directive fromBidiModule. It currently only works whendiris statically set on the body. Tracking #59.