Make speech-dispatcher opt-in so we can avoid LGPL by default #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That doesn't seem right. It's LGPL, but that's not viral in the same way
the GPL is. You can use it as a dependency, you just can't modify it
without contributing back changes. At least, that's my interpretation as
the author of that crate, who just picked that license to be compatible
with that of speech-dispatcher. And I'm pretty sure there are closed
source libraries depending on the native library.
If I'm wrong, please correct me.
|
|
I opened https://gitlab.com/ndarilek/speech-dispatcher-rs/-/issues/2 to
track the relicense. But if you'd like to for now, feel free to develop
under the assumption that the code will ultimately be tri-licensed as
LGPL/MIT/Apache 2.0. I only have the one contributor, and if they don't
agree to the relicense then I'll revert their contributions and rewrite
them myself.
Apologies for the confusion. As the speech-dispatcher crate author, I
don't intend to pursue LGPL license violations on this, particularly as
I'm using it myself in closed-source products. I'll update this PR when
the license change is live.
|
emilk
added a commit
to emilk/egui
that referenced
this pull request
Feb 4, 2022
* Run cargo deny in CI * Use patched fork of ureq to avoid copy-left license * Use patched fork of tts to avoid LGPL license More: * ndarilek/tts-rs#21 * algesten/ureq#479
|
Thank you for responding, and for taking this seriously! A tri-license would be much appreciated. LGPL is difficult to interpret (and I'm not a lawyer), but a common interpretation is that it is fine for non-LGPL code to dynamically link with a LGPL library so that the LGPL library can be updated independently of the application using it. Of course, cargo uses static linking. Again, I'm not a lawyer, but I would sleep better if there were no LGPL rust code in any of my dependencies! https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License#Differences_from_the_GPL |
|
v0.20.2, in the build pipeline now, should resolve this. Please let me
know if this passes cargo-deny for you.
|
emilk
added a commit
to emilk/egui
that referenced
this pull request
Feb 5, 2022
|
Works great - thank you so much @ndarilek ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
speech-dispatcheruses the copy-left LGPL license, which means it cannot be used in any closed source projects. Since this is a default dependency (on linux), it means the wholettscrate becomes impossible to depend on for any crate that would like to not be copy-left.This PR makes it an opt-in dependency. This means using
ttson Linux will by default result in an error, until a user actively adds thespeech-dispatchertotts.I know this isn't ideal, and if anyone has a better suggestion, I'm all ears.
I use
ttsas an opt-in dependency of https://crates.io/crates/egui-winit, and this can cause situations where others may not want to depend on my crate because of the copy-left issue.The problem was discovered thanks to https://github.com/EmbarkStudios/cargo-deny