fix(ui5-select): remove aria-roledescription (SAP#2463)

The reledescription prevents its role of button to be read by JAWS. Fixes SAP#2358
ndeshev · Nov 18, 2020 · 8904e76 · 8904e76
1 parent 37d37b8
commit 8904e76
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 9 deletions.
diff --git a/packages/main/src/Select.hbs b/packages/main/src/Select.hbs
@@ -11,7 +11,6 @@
 	aria-disabled="{{isDisabled}}"
 	aria-required="{{required}}"
 	aria-expanded="{{_isPickerOpen}}"
-	aria-roledescription="{{selectRoleDescription}}"
 	@keydown="{{_onkeydown}}"
 	@keyup="{{_onkeyup}}"
 	@focusin="{{_onfocusin}}"

diff --git a/packages/main/src/Select.js b/packages/main/src/Select.js
@@ -24,7 +24,6 @@ import {
 	VALUE_STATE_ERROR,
 	VALUE_STATE_WARNING,
 	INPUT_SUGGESTIONS_TITLE,
-	SELECT_ROLE_DESCRIPTION,
 } from "./generated/i18n/i18n-defaults.js";
 import Option from "./Option.js";
 import Label from "./Label.js";
@@ -561,10 +560,6 @@ class Select extends UI5Element {
 		return this.disabled || undefined;
 	}
 
-	get selectRoleDescription() {
-		return this.i18nBundle.getText(SELECT_ROLE_DESCRIPTION);
-	}
-
 	get _headerTitleText() {
 		return this.i18nBundle.getText(INPUT_SUGGESTIONS_TITLE);
 	}

diff --git a/packages/main/src/i18n/messagebundle.properties b/packages/main/src/i18n/messagebundle.properties
@@ -286,9 +286,6 @@ RATING_INDICATOR_TEXT=Rating Indicator
 #XACT: ARIA description for the segmented button
 SEGMENTEDBUTTON_ARIA_DESCRIPTION=Segmented button
 
-#XACT: ARIA announcement for the Select`s roledescription attribute
-SELECT_ROLE_DESCRIPTION=Select
-
 #XACT: ARIA announcement for the switch on
 SWITCH_ON=On