Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect type for onChange handler argument #120

Merged
merged 1 commit into from
May 16, 2024

Conversation

ndom91
Copy link
Owner

@ndom91 ndom91 commented Mar 4, 2024

Description

  • Fix onChange argument type from ITimezone (which was a union between the full ITimezoneOption object and string) to ITimezoneOption only.

Since the value can be both a string (i.e. Europe/Berlin) or the full ITimezoneOption object, that's okay, but after going through the component and coming out of the onChange function, so to speak, it'll always be the ITimezoneOption object. Never a string as an argument in onChange.

Linked Issues

Additional context

@ndom91 ndom91 merged commit 827c423 into main May 16, 2024
1 check passed
@ndom91 ndom91 deleted the ndom91/fix-onChange-types branch May 16, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant