Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serial1.end duplication #6

Closed
ndroid opened this issue Oct 3, 2023 · 1 comment
Closed

Serial1.end duplication #6

ndroid opened this issue Oct 3, 2023 · 1 comment
Assignees
@ndroid
Labels
bug Something isn't working

Comments

@ndroid
Copy link
Owner

ndroid commented Oct 3, 2023

If detectDevice() ends with no device detected, the last call to Serial1 if Serial1.end(), but uartBegun is still set to true. Therefore, subsequent calls to detectDevice() will result in repeated call to Serial1.end() which may produce fault in board packages which don't check for Serial status before executing end().
@ndroid ndroid added the bug Something isn't working label Oct 3, 2023
@ndroid ndroid self-assigned this Oct 3, 2023
ndroid added a commit that referenced this issue Oct 9, 2023
@ndroid
corrects uartBegun state to address Issue #6
733a8f5
@ndroid
Copy link
Owner Author

ndroid commented Oct 9, 2023

Addressed by commit 733a8f5

@ndroid ndroid closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndroid ndroid

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ndroid