stop_mocking() should untrace all functions (closes #66, #78) #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nealrichardson
requested changes
Jan 19, 2023
tests/testthat/test-mock-api.R
Outdated
Comment on lines
220
to
221
| for (verb in c("GET", "PUT", "POST", "PATCH", "DELETE", "VERB", "RETRY")) { | ||
| fun <- getFromNamespace(verb, 'httr') |
There was a problem hiding this comment.
So that we don't have to use ::: to get them:
Suggested change
| for (verb in c("GET", "PUT", "POST", "PATCH", "DELETE", "VERB", "RETRY")) { | |
| fun <- getFromNamespace(verb, 'httr') | |
| for (fun_name in c("GET", "PUT", "POST", "PATCH", "DELETE", "VERB", "RETRY", "body_config", "request_perform")) { | |
| fun <- getFromNamespace(fun_name, "httr") |
added 2 commits
January 20, 2023 18:58
nealrichardson
approved these changes
Jan 23, 2023
nealrichardson
changed the title
This was
linked to
issues
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed stop_mocking() that did not untrace all functionstly called safe_untrace. Added corresponding tests. Should fix issue #78 and #66.