Integrate hooks

[amityadav0]

• Add hooks for HoM, CoA, TC
• Add tests

[sczembor]

left few comments. I think we should unit test the methods that were added. If the panics are returned in the correct scenarios

[robert-zaremba]

• documentation should be updated about the new roles.
• need to add a unit test with a whole flow:
  • normal member makes proposal
  • other members vote
  • voting_body vetos the proposal
  • proposal is removed, and people can't vote

[robert-zaremba]

The idea I am thinkging about is integrate the permissions in the existing role based model. We will need to add two new variants to the Action: Veto and Dissolve.

In CoA, we DON'T NEED to define new ProposalKinds (eg no need for Veto, Dismiss). CoA can make a normal FunctionCall proposal to call hom.veto.

Once the proposal succeedes, this will be sent to HoM DAO:

hom.veto(prop_id: u64, reason: String) {
   1. check if caller has "Veto" permisson
   2. check if the proposal is active (or in cooldown - can be in separater PR)
   3. remove proposal and return bond
   4. emit events (separate PR -> task already created)
   5. // maybe I forogt about something
}

In the HoM, the "CoA" role can be defined as:

RolePermission {
     name: "CoA",
     kind: RoleKind::Group(vec![coa_address]),
     permissions: {"Veto", "Dissolve"},  // Need to extend Action enum by adding Veto...
     vote_policy: {}, // empty set - no voting
}

Note: that we use "Veto" here, not ":Veto", because this is not an acto on a proposal. So we will need new function: policy.can_execute_hook, which will only check permissions.contains(&action.to_policy_label())

Note2: later we will need to add one more permission: "Dismiss"

[robert-zaremba]

If we want to extend the RoleKind then we can add RoleKind::Individual(AccountId). But I am not sure if it is needed. And certainly it should not be skipped when doing vote calculation , but in permissions level: https://github.com/near-ndc/astra/blob/8a5f38ba91/astra/src/policy.rs#L329

[amityadav0]

Okay, thanks for the detailed explanation, I have updated the PR with the changes

[robert-zaremba]

nearly there