Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional category to proposal #8

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Add optional category to proposal #8

merged 3 commits into from
Sep 26, 2023

Conversation

amityadav0
Copy link

@amityadav0 amityadav0 commented Sep 26, 2023

  • add optional category
  • add test
  • add doc

Copy link

@sczembor sczembor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add information with an example of category to README

@amityadav0
Copy link
Author

added

@amityadav0 amityadav0 changed the title [Astra++] add optional category arg to add_proposal Astra++: add optional category arg to add_proposal Sep 26, 2023
@amityadav0 amityadav0 changed the title Astra++: add optional category arg to add_proposal Add optional category to proposal Sep 26, 2023
Copy link

@robert-zaremba robert-zaremba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amityadav0 amityadav0 merged commit 544ff32 into master Sep 26, 2023
1 check passed
@amityadav0 amityadav0 deleted the arg branch September 26, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants