-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEP-368: Bridge Wallet Standard #368
Merged
MaximusHaximus
merged 25 commits into
near:master
from
lewis-sqa:SQC-159/bridge-wallets-nep
Sep 6, 2022
Merged
NEP-368: Bridge Wallet Standard #368
MaximusHaximus
merged 25 commits into
near:master
from
lewis-sqa:SQC-159/bridge-wallets-nep
Sep 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 8, 2022
frol
added
the
WG-wallet-standards
Wallet Standards Work Group should be accountable
label
Sep 5, 2022
14 tasks
MaximusHaximus
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3 @lewis-sqa thanks for your hard work on this standard!
Made a couple of small nit-picky tweaks, I think this is ready to roll <3 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a proposal for a new NEP regarding a Bridge Wallet Standard to bring official support for NEAR to WalletConnect and Nightly Connect.
Demo
You can find a demo of this standard for WalletConnect using the two projects detailed below:
projectId
.projectId
in https://github.com/near/wallet-selector/blob/SQC-170/bridge-wallet-poc/examples/react/src/contexts/WalletSelectorContext.tsx.yarn && yarn build:modal-ui && yarn build:all && yarn serve:react
from root.projectId
.cp .env.local.example .env.local
fromdapps/react-dapp-v2
and updateNEXT_PUBLIC_PROJECT_ID
.yarn && yarn dev
fromdapps/react-dapp-v2
.