Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(source-scan): docker checks #166

Merged
merged 31 commits into from
Jun 19, 2024
Merged

feat(source-scan): docker checks #166

merged 31 commits into from
Jun 19, 2024

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented May 28, 2024 •
edited
Loading

fast-forward extension of #164

  1. Cargo.toml => sample-crate-12.testnet
contract_source_metadata

{
  "build_info": {
    "build_command": [
      "cargo",
      "near",
      "build",
      "--no-default-features",
      "--features",
      "near-sdk/expensive-debug"
    ],
    "build_environment": "dj8yfo/sourcescan:0.x.x-dev-cargo-near-finalization@sha256:f86a095cb3daed21d0b5f86a4b5d9da0c0e26835f85c42678e1d460c9caa2c12",
    "contract_path": "",
    "source_code_snapshot": "git+https://github.com/dj8yfo/sample_no_workspace.git?rev=1fd39bcbe4d523ac26c3d07c1f49ecc0fc65d9e7"
  },
  "link": "https://github.com/dj8yfo/sample_no_workspace/tree/1fd39bcbe4d523ac26c3d07c1f49ecc0fc65d9e7",
  "standards": [
    {
      "standard": "nep330",
      "version": "1.2.0"
    }
  ],
  "version": "0.7.7"
}

  1. Cargo.toml => sample-subpath-in-repo-6.testnet
contract_source_metadata

{
  "build_info": {
    "build_command": [
      "cargo",
      "near",
      "build",
      "--no-release",
      "--no-doc"
    ],
    "build_environment": "dj8yfo/sourcescan:0.x.x-dev-cargo-near-finalization@sha256:f86a095cb3daed21d0b5f86a4b5d9da0c0e26835f85c42678e1d460c9caa2c12",
    "contract_path": "self-updates/update",
    "source_code_snapshot": "git+https://github.com/dj8yfo/sample_workspace.git?rev=86aa6ccf4610f072cd207db86869e6324779780f"
  },
  "link": "https://github.com/dj8yfo/sample_workspace/tree/86aa6ccf4610f072cd207db86869e6324779780f",
  "standards": [
    {
      "standard": "nep330",
      "version": "1.2.0"
    }
  ],
  "version": "1.7.7"
}

  1. dir containing submodule => sample-crate-in-submodule-5.testnet
contract_source_metadata

{
  "build_info": {
    "build_command": [
      "cargo",
      "near",
      "build",
      "--no-release",
      "--no-doc"
    ],
    "build_environment": "dj8yfo/sourcescan:0.x.x-dev-cargo-near-finalization@sha256:f86a095cb3daed21d0b5f86a4b5d9da0c0e26835f85c42678e1d460c9caa2c12",
    "contract_path": "self-updates/update",
    "source_code_snapshot": "git+https://github.com/dj8yfo/sample_workspace_with_submodules.git?rev=4b466921b89df67d6e8d1f9956b55a677edb2497"
  },
  "link": "https://github.com/dj8yfo/sample_workspace_with_submodules/tree/4b466921b89df67d6e8d1f9956b55a677edb2497",
  "standards": [
    {
      "standard": "nep330",
      "version": "1.2.0"
    }
  ],
  "version": "1.0.0"
}

  1. Cargo.toml => bitbucket-scratch-4.testnet
contract_source_metadata

{
  "build_info": {
    "build_command": [
      "cargo",
      "near",
      "build",
      "--no-release",
      "--no-doc"
    ],
    "build_environment": "dj8yfo/sourcescan:0.x.x-dev-cargo-near-finalization@sha256:f86a095cb3daed21d0b5f86a4b5d9da0c0e26835f85c42678e1d460c9caa2c12",
    "contract_path": "",
    "source_code_snapshot": "git+https://feepdake27@bitbucket.org/dj8yfomule/scratch_check_git.git?rev=af9e835380053205f7fcc9b232a7ebb1c2c20694"
  },
  "link": "https://bitbucket.org/dj8yfomule/scratch_check_git/src/finalization/",
  "standards": [
    {
      "standard": "nep330",
      "version": "1.2.0"
    }
  ],
  "version": "0.1.0"
}

  1. factory Cargo.toml => repro-fct-19.testnet
contract_source_metadata

{
  "build_info": {
    "build_command": [
      "cargo",
      "near",
      "build",
      "--no-default-features",
      "--features",
      "near-sdk/expensive-debug"
    ],
    "build_environment": "dj8yfo/sourcescan:0.x.x-dev-cargo-near-finalization@sha256:f86a095cb3daed21d0b5f86a4b5d9da0c0e26835f85c42678e1d460c9caa2c12",
    "contract_path": "factory",
    "source_code_snapshot": "git+https://github.com/dj8yfo/factory-rust.git?rev=62a34ac86e6323ee6351b20fded7fc668b1e0277"
  },
  "link": "https://github.com/dj8yfo/factory-rust/tree/62a34ac86e6323ee6351b20fded7fc668b1e0277",
  "standards": [
    {
      "standard": "nep330",
      "version": "1.2.0"
    }
  ],
  "version": "0.1.13"
}

  1. repro-fct-19.testnet => product donation-product.repro-fct-19.testnet
contract_source_metadata

{
  "build_info": {
    "build_command": [
      "cargo",
      "near",
      "build"
    ],
    "build_environment": "dj8yfo/sourcescan:0.x.x-dev-cargo-near-finalization@sha256:f86a095cb3daed21d0b5f86a4b5d9da0c0e26835f85c42678e1d460c9caa2c12",
    "contract_path": "product-donation",
    "source_code_snapshot": "git+https://github.com/dj8yfo/factory-rust.git?rev=62a34ac86e6323ee6351b20fded7fc668b1e0277"
  },
  "link": "https://github.com/dj8yfo/factory-rust/tree/62a34ac86e6323ee6351b20fded7fc668b1e0277",
  "standards": [
    {
      "standard": "nep330",
      "version": "1.2.0"
    }
  ],
  "version": "0.2.9"
}

  1. product Cargo.toml => repro-fct-product-19.testnet
contract_source_metadata

{
  "build_info": {
    "build_command": [
      "cargo",
      "near",
      "build"
    ],
    "build_environment": "dj8yfo/sourcescan:0.x.x-dev-cargo-near-finalization@sha256:f86a095cb3daed21d0b5f86a4b5d9da0c0e26835f85c42678e1d460c9caa2c12",
    "contract_path": "product-donation",
    "source_code_snapshot": "git+https://github.com/dj8yfo/factory-rust.git?rev=62a34ac86e6323ee6351b20fded7fc668b1e0277"
  },
  "link": "https://github.com/dj8yfo/factory-rust/tree/62a34ac86e6323ee6351b20fded7fc668b1e0277",
  "standards": [
    {
      "standard": "nep330",
      "version": "1.2.0"
    }
  ],
  "version": "0.2.9"
}

dj8yf0μl added 14 commits May 14, 2024 21:21
chore: set CARGO_NEAR_BUILD_COMMAND only if unset previously
4f6e302
feat: add print of bin hashsum to ArtifactMessages
9de9279
chore: export env var, indicating that abi is being generated
c62e17b
chore: export build fn and its arg type
62d7bcf
ci: fix clippy
41a4cc0
chore: add wrapping msg for missing commit on remote
69f0c0b
chore: print hex format of code checksum as well
5ef7893
feat: compute CARGO_NEAR_BUILD_COMMAND either from cli args or from…
210e8e3 
… lib build `Opts`
chore: make BuildArtifact the return type of `cargo_near::build_ext…
815b727 
…ended`
chore: generalize BuildOptsExtended
7d2e11d
doc: improve doc a bit on added opts
5e48ff3
chore: replace contains with ends_with
fbed198
chore: remove docker interactive run with `CARGO_NEAR_SERVER_BUILD_DI…
b3f7044 
…SABLE_INTERACTIVE`
feat: docker sanity check + image check
fc966ca
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented May 28, 2024 •
edited
Loading

no_bin_linux
perm_denied_linux

no_image_linux
no_bin_mac

no_nested_virtualization_windows

@dj8yfo dj8yfo force-pushed the source-scan-docker-checks2 branch 3 times, most recently from c85a5c7 to fc966ca Compare May 28, 2024 17:34
@dj8yfo dj8yfo marked this pull request as ready for review May 28, 2024 18:20
@dj8yfo dj8yfo force-pushed the source-scan-docker-checks2 branch 3 times, most recently from 2a07d49 to ac64571 Compare May 29, 2024 18:35
frol
frol requested changes Jun 5, 2024
View reviewed changes
cargo-near/src/commands/build_command/build.rs Outdated Show resolved Hide resolved
cargo-near/src/commands/build_command/build.rs Outdated Show resolved Hide resolved
cargo-near/src/util/mod.rs Outdated Show resolved Hide resolved
cargo-near/src/commands/build_command/mod.rs Outdated Show resolved Hide resolved
cargo-near/src/commands/build_command/docker/git_checks/pushed_to_remote.rs Outdated Show resolved Hide resolved
cargo-near/src/commands/build_command/docker/docker_checks/hello_world.rs Outdated Show resolved Hide resolved
cargo-near/src/commands/abi_command/abi.rs Show resolved Hide resolved
cargo-near/src/build_extended/build_script.rs Outdated Show resolved Hide resolved
@dj8yfo dj8yfo mentioned this pull request Jun 6, 2024
Closed
@dj8yfo dj8yfo marked this pull request as draft June 11, 2024 11:21
@dj8yfo dj8yfo force-pushed the source-scan-docker-checks2 branch from cadbeb9 to 48b8181 Compare June 17, 2024 14:16
@dj8yfo dj8yfo marked this pull request as ready for review June 17, 2024 14:44
frol
frol approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dj8yfo Great job!

@frol frol merged commit 21bd5bc into near:source-scan-integration Jun 19, 2024
14 checks passed
@dj8yfo dj8yfo mentioned this pull request Jul 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dj8yfo @frol