added assertion that asserts that the amount being transfered is larger than 0 #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasperdg
requested review from
bowenwang1996,
evgenykuzyakov and
willemneal
as code owners
jasperdg
changed the title
bowenwang1996
approved these changes
Feb 15, 2021
evgenykuzyakov
requested changes
Feb 16, 2021
| @@ -171,7 +176,10 @@ impl FungibleTokenResolver for Contract { | |||
| amount | |||
| } | |||
| } | |||
| PromiseResult::Failed => amount, | |||
| PromiseResult::Failed => { | |||
| Promise::new(sender_id.to_string()).transfer(initial_storage_deposit.into()); | |||
There was a problem hiding this comment.
This can be abused, since the receiver can return a promise that fails, which doesn't generate a refund.
So this fungible contract core implementation can't be sure that there was refund.
It's a limitation of NEAR protocol cross-contracts right now.
|
The StorageManager trait is not fully compliant with the proposed standard interface.
fn storage_withdraw(&mut self, amount: Option<U128>) -> AccountStorageBalance; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no use-case for transferring 0 tokens to an account and it could cause overflows on receiving contract's end.